Skip to content

feat: clone user context #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ozayr-zaviar wants to merge 4 commits into from
Closed

feat: clone user context #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e03e0fe
clone function created and passed as argument
ozayr-zaviar Jan 12, 2021
f2e14a6
linting fixed
ozayr-zaviar Jan 12, 2021
c649b1b
white space removed
ozayr-zaviar Jan 12, 2021
2f1ae2c
unit test added for clone
ozayr-zaviar Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions optimizely/user_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ def __init__(self, optimizely_client, user_id, user_attributes=None):

self.logger = _logging.reset_logger(self.logger_name)

def clone(self):
return UserContext(self.client, self.user_id, self.user_attributes)

def set_attribute(self, attribute_key, attribute_value):
"""
sets a attribute by key for this user context.
Expand All @@ -66,7 +69,7 @@ def decide(self, key, options=None):
self.logger.error("Optimizely Client invalid")
return None

return self.client.decide(self, key, options)
return self.client.decide(self.clone(), key, options)

def decide_for_keys(self, keys, options=None):
"""
Expand All @@ -82,7 +85,7 @@ def decide_for_keys(self, keys, options=None):
self.logger.error("Optimizely Client invalid")
return None

self.client.decide_for_keys(self, keys, options)
self.client.decide_for_keys(self.clone(), keys, options)

def decide_all(self, options=None):
"""
Expand All @@ -97,7 +100,7 @@ def decide_all(self, options=None):
self.logger.error("Optimizely Client invalid")
return None

self.client.decide_all(self, options)
self.client.decide_all(self.clone(), options)

def track_event(self, event_key, event_tags=None):
self.client.track(event_key, self.user_id, self.user_attributes, event_tags)
11 changes: 11 additions & 0 deletions tests/test_user_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,17 @@ def test_decide_rollout(self):
self.assertFalse(decision.enabled)
self.assertEqual(decision.flag_key, 'test_feature_in_rollout')

def test_decide_user_context(self):
""" Test that the user context in decide response is not the same object on which
the decide was called """

opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))

user_context = opt_obj.create_user_context('test_user')
decision = user_context.decide('test_feature_in_rollout')
user_context.set_attribute("test_key", "test_value")
self.assertNotEqual(user_context.user_attributes, decision.user_context.user_attributes)

def test_decide_for_keys(self):
""" Test that the feature is enabled for the user if bucketed into variation of a rollout.
Also confirm that no impression event is processed. """
Expand Down