-
Notifications
You must be signed in to change notification settings - Fork 36
feat: Added support for Authenticated Datafiles #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f916fb2
add enum constants for auth datafile
pthompson127 3eb82ed
create AuthDatafileConfigManager which extends PollingConfigManager a…
pthompson127 20d1fff
override fetch_datafile method in AuthDatafilePollingConfigManager to…
pthompson127 6b26499
add import statement for AuthDatafilePollingConfigManager and add con…
pthompson127 151e6f9
add setter method for access_token
pthompson127 5432661
add 3 tests for AuthDatafilePollingConfigManager
pthompson127 933caf6
modify expected_datafile_url to use presets in enums for consistency
pthompson127 409c849
add test for optimizely.py for condition where AuthDatafilePollingCon…
pthompson127 bc3b896
modify access_token input check to disallow an empty or None access_t…
pthompson127 2bf8305
style: fix linting issues
pthompson127 7993095
style: remove whitespace for linting
pthompson127 5900b8d
style: rewrite test comment
pthompson127 ca30935
refactor: reorder constructor argument for access_token
pthompson127 0734e0f
refactor: change args to **kwargs and add a url_template setter method
pthompson127 c1afef2
docs: add method comments
pthompson127 12aac02
refactor: convert to *args and **kwargs and remove url setter method
pthompson127 deca4da
docs: add constructor comment
pthompson127 19493a2
refactor: make requested changes
pthompson127 058d728
Merge branch 'master' into peter/datafile-auth-v2
pawels-optimizely File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.