feat: Cache OptimizelyConfig and set Pyyaml version#234
Merged
Conversation
2 similar comments
jaeopt
requested changes
Jan 13, 2020
Contributor
jaeopt
left a comment
There was a problem hiding this comment.
Looks good. One missing test case is to validate OptConfig data updated correctly after datafile changes. Can we add it?
Contributor
Author
Added. Please check. |
thomaszurkan-optimizely
approved these changes
Jan 15, 2020
Contributor
Author
|
@thomaszurkan-optimizely @msohailhussain I have fixed pyyaml version to 5.2 since the latest release only supports Python 2.7 or Python 3.5+. Have also updated the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizely Config cached in Config Manager. OptimizelyConfig should only be created on datafile update. Otherwise, Config Manager should return a cached copy.
Set Pyyaml version to 5.2 since the latest version 5.3 only works with Python 3.5+. And we need to run tests with Python 3.4 on Travis
Test plan
Issues
OASIS-5791