refac: findValidatedForcedDecision method moved to decision service#730
Merged
Conversation
| reasons: decideReasons, | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
import logger on line 16 and get_logger on line 35 can be removed.
zashraf1985
approved these changes
Jan 6, 2022
Contributor
zashraf1985
left a comment
There was a problem hiding this comment.
LGTM! with a non binding suggestion.
| let variation = null; | ||
| let variationKey; | ||
| const userId = user.getUserId() | ||
| if (config && forcedDecision) { |
Contributor
There was a problem hiding this comment.
Suggestion (non binding): If we move the check for config at the top, we will save a redundant call to getForcedDecision when config is not available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All unit test and FSC tests should pass.