Skip to content

🐛 Fix manifest generation drift - #3033

Closed
perdasilva wants to merge 1 commit into
operator-framework:mainfrom
perdasilva:fix-manifest-drift
Closed

perdasilva wants to merge 1 commit into
operator-framework:mainfrom
perdasilva:fix-manifest-drift

Conversation

@perdasilva

@perdasilva perdasilva commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

It seems there's been some drift in the structure of the generated manifests. Its trivial though: a missing empty comment line...

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Summary by CodeRabbit

  • Documentation
    • Improved spacing and clarity across generated configuration reference comments.
    • Clarified documentation for image-based sources and related configuration fields.
    • No runtime behavior, public declarations, or API signatures changed.

@netlify

netlify Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6f0944a
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6ad718faa2c7f3e7e578932e
😎 Deploy Preview https://deploy-preview-3033--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 6f1aa643-2667-484f-9273-3b77ca13ba89
📥 Commits

Reviewing files that changed from the base of the PR and between d10c784 and 6f0944a.

📒 Files selected for processing: 23
  • applyconfigurations/api/v1/bundlemetadata.go
  • applyconfigurations/api/v1/catalogfilter.go
  • applyconfigurations/api/v1/catalogsource.go
  • applyconfigurations/api/v1/clustercatalogspec.go
  • applyconfigurations/api/v1/clustercatalogstatus.go
  • applyconfigurations/api/v1/clustercatalogurls.go
  • applyconfigurations/api/v1/clusterextensionconfig.go
  • applyconfigurations/api/v1/clusterextensioninstallconfig.go
  • applyconfigurations/api/v1/clusterextensioninstallstatus.go
  • applyconfigurations/api/v1/clusterextensionspec.go
  • applyconfigurations/api/v1/clusterextensionstatus.go
  • applyconfigurations/api/v1/clusterobjectsetobject.go
  • applyconfigurations/api/v1/clusterobjectsetphase.go
  • applyconfigurations/api/v1/clusterobjectsetspec.go
  • applyconfigurations/api/v1/clusterobjectsetstatus.go
  • applyconfigurations/api/v1/crdupgradesafetypreflightconfig.go
  • applyconfigurations/api/v1/imagesource.go
  • applyconfigurations/api/v1/objectsourceref.go
  • applyconfigurations/api/v1/observedphase.go
  • applyconfigurations/api/v1/resolvedcatalogsource.go
  • applyconfigurations/api/v1/revisionstatus.go
  • applyconfigurations/api/v1/serviceaccountreference.go
  • applyconfigurations/api/v1/sourceconfig.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Walkthrough

Generated API apply-configuration comments have spacing updates. The catalog source comment now identifies the image-source behavior for type: "Image". Field declarations and runtime behavior are unchanged.

Changes: Apply-configuration documentation

Layer / File(s) Summary
Generated comment updates
applyconfigurations/api/v1/bundlemetadata.go, applyconfigurations/api/v1/catalogfilter.go, applyconfigurations/api/v1/catalogsource.go, applyconfigurations/api/v1/clustercatalogspec.go, applyconfigurations/api/v1/clustercatalogstatus.go, applyconfigurations/api/v1/clustercatalogurls.go, applyconfigurations/api/v1/clusterextensionconfig.go, applyconfigurations/api/v1/clusterextensioninstallconfig.go, applyconfigurations/api/v1/clusterextensioninstallstatus.go, applyconfigurations/api/v1/clusterextensionspec.go, applyconfigurations/api/v1/clusterextensionstatus.go, applyconfigurations/api/v1/clusterobjectsetobject.go, applyconfigurations/api/v1/clusterobjectsetphase.go, applyconfigurations/api/v1/clusterobjectsetspec.go, applyconfigurations/api/v1/clusterobjectsetstatus.go, applyconfigurations/api/v1/crdupgradesafetypreflightconfig.go, applyconfigurations/api/v1/imagesource.go, applyconfigurations/api/v1/objectsourceref.go, applyconfigurations/api/v1/observedphase.go, applyconfigurations/api/v1/resolvedcatalogsource.go, applyconfigurations/api/v1/revisionstatus.go, applyconfigurations/api/v1/serviceaccountreference.go, applyconfigurations/api/v1/sourceconfig.go
Generated field comments received spacing changes. The catalog source comment clarifies that an image source is used when type is "Image". No declarations or runtime behavior changed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: tmshort

Merge Risk: ⚪ Minimal · up to 6f094

This documentation-only PR is mergeable with no actionable current-head risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title is concise, uses the required bug-fix prefix, and accurately describes the manifest generation drift correction.
Description check Passed The description includes the required Description section and Reviewer Checklist. It clearly states the manifest drift issue and the missing empty comment line. Test results and related issue links ar…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Description section and Reviewer Checklist. It clearly states the manifest drift issue and the missing empty comment line. Test results and related issue links are not provided, but the description is mostly complete for this documentation-only change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 23 files.

✨ Finishing Touches: 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2026
@openshift-ci

openshift-ci Bot commented Oct 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rashmigottipati
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva

Copy link
Copy Markdown
Contributor Author

seems like the problem is on my environment =P

@perdasilva perdasilva closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants