Skip to content

feat: use CRD generator#350

Merged
adam-sandor merged 9 commits into
masterfrom
use-crd-generator
Mar 1, 2021
Merged

feat: use CRD generator#350
adam-sandor merged 9 commits into
masterfrom
use-crd-generator

Conversation

@metacosm
Copy link
Copy Markdown
Collaborator

@metacosm metacosm commented Feb 24, 2021 •
edited
Loading

Fixes #110.

@metacosm metacosm requested a review from adam-sandor February 24, 2021 21:12
@metacosm metacosm self-assigned this Feb 24, 2021
@metacosm metacosm mentioned this pull request Feb 25, 2021
Closed
@adam-sandor
Copy link
Copy Markdown
Collaborator

adam-sandor commented Feb 25, 2021

Code looks good, but when I tried to use it in the memcached operator I'm getting this error:

[INFO] Compiling 7 source files to C:\Users\adams\IdeaProjects\memcached-operator\target\classes
Generating 'memcacheds.cache.example.com' version 'v1alpha1' with io.javaoperatorsdk.sample.memcached.Memcached (spec: io.javaoperatorsdk.sample.memcached.MemcachedSpec / status: io.javaoperatorsdk.sample.memcached.MemcachedStatus)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.426 s
[INFO] Finished at: 2021-02-25T10:59:24+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project memcached-operator: Fatal error compiling: java.lang.NoClassDefFoundError: io/fabric8/kubernetes/model/annotation/ShortNames: io.fabric8.kubernetes.model.annotation.ShortNames -> [Help 1]

adam-sandor
adam-sandor reviewed Feb 25, 2021
View reviewed changes
Comment thread README.md
```

The CRD will be generated in `target/classes/META-INF/fabric8` (or
in `target/test-classes/META-INF/fabric8`, if you use the `test` scope) with the CRD name suffixed
Copy link
Copy Markdown
Collaborator

@adam-sandor adam-sandor Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this is the best place to put the generated files... Why here? Why not in resources or even in the kubernetes directory next to the generated deployment yaml?

Copy link
Copy Markdown
Collaborator Author

@metacosm metacosm Feb 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because that's where fabric8 tools have traditionally put their generated files. Also, worth noting that the deployment manifest is generated by a different process (I'm assuming you're talking about the manifests generated by the quarkus extension, here) and, while it would be nice for every tool to generate things at the same spot, these tools are not supposed to know about one another and could evolve separately.
I agree, though, that it would be nice if everything was generated at the same spot. Can you please open a fabric8 ticket for this?

Copy link
Copy Markdown
Collaborator Author

@metacosm metacosm Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See fabric8io/kubernetes-client#2842.

Copy link
Copy Markdown
Collaborator

@adam-sandor adam-sandor Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you already did, thanks!

@metacosm
Copy link
Copy Markdown
Collaborator Author

metacosm commented Feb 25, 2021 •
edited
Loading

Code looks good, but when I tried to use it in the memcached operator I'm getting this error:

[INFO] Compiling 7 source files to C:\Users\adams\IdeaProjects\memcached-operator\target\classes
Generating 'memcacheds.cache.example.com' version 'v1alpha1' with io.javaoperatorsdk.sample.memcached.Memcached (spec: io.javaoperatorsdk.sample.memcached.MemcachedSpec / status: io.javaoperatorsdk.sample.memcached.MemcachedStatus)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.426 s
[INFO] Finished at: 2021-02-25T10:59:24+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project memcached-operator: Fatal error compiling: java.lang.NoClassDefFoundError: io/fabric8/kubernetes/model/annotation/ShortNames: io.fabric8.kubernetes.model.annotation.ShortNames -> [Help 1]

Let me check but I suspect that's because the memcached operator uses a mix of different fabric8 client versions… How did you add the crd-generator?

@metacosm
Copy link
Copy Markdown
Collaborator Author

metacosm commented Feb 25, 2021

OK, that is indeed an issue. It's possible to work around it but we need to address this more cleanly. See java-operator-sdk/memcached-operator-sample#2

@metacosm metacosm mentioned this pull request Feb 25, 2021
Closed
@metacosm
Copy link
Copy Markdown
Collaborator Author

metacosm commented Feb 25, 2021

I've created an issue to simplify the dependencies: fabric8io/kubernetes-client#2840

@snowdrop-bot snowdrop-bot mentioned this pull request Feb 25, 2021
Closed
adam-sandor
adam-sandor reviewed Feb 25, 2021
View reviewed changes
Comment thread README.md
<artifactId>crd-generator</artifactId>
<scope>compile</scope>
</dependency>
```
Copy link
Copy Markdown
Collaborator

@adam-sandor adam-sandor Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add the dependency on <dependency> <groupId>io.fabric8</groupId> <artifactId>kubernetes-model-common</artifactId> </dependency> here?

Copy link
Copy Markdown
Collaborator Author

@metacosm metacosm Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Can we merge this now?

@adam-sandor
Copy link
Copy Markdown
Collaborator

adam-sandor commented Feb 25, 2021

added one more comment, otherwise all looks good!

@adam-sandor adam-sandor merged commit 9b82802 into master Mar 1, 2021
@metacosm metacosm deleted the use-crd-generator branch March 1, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adam-sandor adam-sandor adam-sandor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@metacosm metacosm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate CRD from Custom Resource POJO

2 participants

@metacosm @adam-sandor