Skip to content

test: fix flaky additionalFinalizer in TriggerReconcilerOnAllEventIT #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csviri wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: fix flaky additionalFinalizer in TriggerReconcilerOnAllEventIT #3434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ff843c
test: fix flaky additionalFinalizer in TriggerReconcilerOnAllEventIT
csviri Jun 19, 2026
a6a7fc4
format
csviri Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...aoperatorsdk/operator/baseapi/triggerallevent/eventing/TriggerReconcilerOnAllEventIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,17 @@ void additionalFinalizer() {

extension.create(res);

// Wait until the operator has added its own finalizer before deleting. Right after create the
// resource already has exactly [ADDITIONAL_FINALIZER], so without this the assertion below
// could
// pass prematurely (before the add/mark-for-deletion/remove cycle), snapshotting a stale event
// count and making the phase-2 `eventCount + 1` assertion flaky.
await()
.untilAsserted(
() ->
assertThat(getResource().getMetadata().getFinalizers())
.containsExactlyInAnyOrder(ADDITIONAL_FINALIZER, FINALIZER));

extension.delete(getResource());

await()
Expand Down
Loading