Conversation
There was a problem hiding this comment.
Pull request overview
This PR centralizes OpenVINO / GenAI / Tokenizers version pins and binary package URLs into a shared versions.mk, then updates both the Linux build flow (Makefile) and Windows dependency install script to consume those shared version definitions.
Changes:
- Introduces
versions.mkas the single source of truth for OV/GenAI/Tokenizers git refs, orgs, and package URLs. - Updates
Makefiletoinclude versions.mkand use per-OS package URL variables. - Updates
windows_install_build_dependencies.batto load defaults fromversions.mkand use the new variable names.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| windows_install_build_dependencies.bat | Loads version defaults from versions.mk and switches to OV_* variables for source builds. |
| versions.mk | New shared version manifest for git refs/orgs and OS-specific GenAI/OpenVINO package URLs. |
| Makefile | Includes versions.mk and uses its OS-specific package URL variables. |
| ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: | ||
| :: Load dependency version defaults from shared versions.mk (only sets variables not already in environment) | ||
| for /f "usebackq eol=# tokens=1,* delims= ?=" %%A in ("%~dp0versions.mk") do ( | ||
| if not "%%A"=="" if not "%%B"=="" call :setifempty "%%A" "%%B" |
There was a problem hiding this comment.
The new versions.mk parsing calls :setifempty, but there is no :setifempty label/subroutine defined in this batch file. On Windows this will fail with “cannot find the batch label specified” and prevent dependency installation. Add the missing :setifempty implementation (or replace this with inline logic) so the script can successfully load defaults from versions.mk.
| if not "%%A"=="" if not "%%B"=="" call :setifempty "%%A" "%%B" | |
| if not "%%A"=="" if not "%%B"=="" ( | |
| call set "current_value=%%%A%%" | |
| if not defined current_value set "%%A=%%B" | |
| set "current_value=" | |
| ) |
| OV_TOKENIZERS_ORG ?= openvinotoolkit | ||
| # Dependency versions (git commits, orgs, package version) are centralised in versions.mk. | ||
| # Override any variable via the environment or command-line before invoking make. | ||
| include versions.mk |
There was a problem hiding this comment.
ifeq ($(wildcard versions.mk),)
$(error versions.mk was not included or does not exist)
endif
There was a problem hiding this comment.
Why this condition? I'm not sure how it could be missing while it is in git src.
If missing, make raise an error anyway:
Makefile:80: versions.mk: No such file or directory
make: *** No rule to make target 'versions.mk'. Stop.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
🛠 Summary
Update OV Runtime to 0407 version
Unify version management for OV components
🧪 Checklist
``