Allow Newtonsoft.Json 10.x#653
Merged
Merged
Conversation
Contributor
|
I think opening up the ceiling for versions should be fine unless we run into problems with backwards compatibility at some point. For now, I think this should be fine. |
Contributor
Author
|
@dwalleck, can we get a new NuGet release with this change? |
|
+1 ? |
|
I'm giving a hand to @dwalleck to make a new build. In the meanwhile, anyone using paket framework and facing the issue still a workaround would be to lock the Newtonsoft.Json to a specific release in paket.dependencies, like (downside, you won't get automatically updating Newtonsoft.Json package though) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it is best to just remove the maximum version number for Newtonsoft.Json. Most other NuGet packages I have looked at use this approach with Newtonsoft.Json.
I'm also happy to change the range to be "[6.0.1,11.0)", if that's what the maintainers would prefer. But since this project doesn't seem very actively maintained, I think just removing the max version will allow more people to continue to use it without this being a recurring issue.