Merge of DSA reallocation fix.#7513
Closed
paulidale wants to merge 1 commit intoopenssl:OpenSSL_1_0_2-stablefrom
Closed
Merge of DSA reallocation fix.#7513paulidale wants to merge 1 commit intoopenssl:OpenSSL_1_0_2-stablefrom
paulidale wants to merge 1 commit intoopenssl:OpenSSL_1_0_2-stablefrom
Conversation
Closed
levitte
approved these changes
Oct 29, 2018
Member
levitte
left a comment
There was a problem hiding this comment.
I'm not entirely happy with this direct reach into BIGNUM, but can't currently see a more elegant way.
Contributor
Maybe I'm slow this morning, but isn't the same as |
Contributor
Author
|
Yes, those two sizeofs are the same. |
levitte
pushed a commit
that referenced
this pull request
Oct 29, 2018
Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #7513)
Contributor
Author
|
Merged thanks. |
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Nov 14, 2018
Low severity timing vulnerability in the DSA signature algorithm Publicly disclosed but unreleased, pending OpenSSL 1.0.2q Ref: openssl/openssl#7486 Ref: openssl/openssl#7513 Ref: https://www.openssl.org/news/secadv/20181030.txt Ref: nodejs#23965 Upstream: openssl/openssl@a9cfb8c2 Upstream: openssl/openssl@43e6a58d Original commit message: Avoid a timing attack that leaks information via a side channel that triggers when a BN is resized. Increasing the size of the BNs prior to doing anything with them suppresses the attack. Thanks due to Samuel Weiser for finding and locating this. Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from openssl/openssl#7486) Original backport commit message: Merge DSA reallocation timing fix CVE-2018-0734. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from openssl/openssl#7513)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timing vulnerability in DSA signature generation (CVE-2018-0734)
Preallocate two extra limbs for some of the big numbers to avoid a reallocation
that can potentially provide a side channel.