Make SSL_CTX_set_cert_store increase the reference counter#1795
Closed
kroeckx wants to merge 1 commit intoopenssl:masterfrom
Closed
Make SSL_CTX_set_cert_store increase the reference counter#1795kroeckx wants to merge 1 commit intoopenssl:masterfrom
kroeckx wants to merge 1 commit intoopenssl:masterfrom
Conversation
Contributor
|
This has been the behavior since SSLeay 0.8.1b, so it's probably not reasonable to change at this point. Calling free while not taking a reference is consistent with all the other Though given that this function already was split into |
Member
Author
|
I assume this was a new function, but you're right it's not. And the new functions already do the right thing it seems, so maybe I should just use those instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if we covered something like this in our discussion about the style guide. But I think since it's freeing the old one, it should increase reference counter for the new one.
This came up in nodejs/node#8491 (review)