Skip to content

Handle header_params same as upstream #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabianvf merged 1 commit into from
Jun 22, 2021
+9 −7
Merged

Handle header_params same as upstream #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions openshift/dynamic/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def watch(self, resource, namespace=None, name=None, label_selector=None, field_
yield event

@meta_request
def request(self, method, path, body=None, accept_header=None, **params):
def request(self, method, path, body=None, **params):
if not path.startswith('/'):
path = '/' + path

Expand Down Expand Up @@ -216,12 +216,14 @@ def request(self, method, path, body=None, accept_header=None, **params):
header_params = params.get('header_params', {})
form_params = []
local_var_files = {}
# HTTP header `Accept`
header_params['Accept'] = accept_header or self.client.select_header_accept([
'application/json',
'application/yaml',
'application/vnd.kubernetes.protobuf'
])

# Checking Accept header.
new_header_params = dict((key.lower(), value) for key, value in header_params.items())
if not 'accept' in new_header_params:
header_params['Accept'] = self.client.select_header_accept([
'application/json',
'application/yaml',
])

# HTTP header `Content-Type`
if params.get('content_type'):
Expand Down