Add an option to provide "Accept" header to client request#406
Merged
Conversation
Signed-off-by: Nir Argaman <nargaman@redhat.com>
Member
|
/lgtm |
fabianvf
approved these changes
Jun 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianvf, nirarg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/hold |
Member
|
/cherrypick release-0.12 |
|
@fabianvf: new pull request created: #408 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
client.requestfunction always use the same accept header (application/json) which in some cases can be wrongTherefore, add an option to the caller to add the required header
Default behavior (caller doesn't provide the header) stays the same