Skip to content

[WIP] OpenMMToolsMCEngine#1041

Draft
dwhswenson wants to merge 12 commits into
openpathsampling:masterfrom
dwhswenson:openmmtools_mc_engine
Draft

[WIP] OpenMMToolsMCEngine#1041
dwhswenson wants to merge 12 commits into
openpathsampling:masterfrom
dwhswenson:openmmtools_mc_engine

Conversation

@dwhswenson

@dwhswenson dwhswenson commented Jul 28, 2021

Copy link
Copy Markdown
Member

This provides an engine that wraps the tools in openmmtools.mcmc. This will allow users to perform path sampling simulations of Monte Carlo "trajectories."

  • Basic dynamics
  • Serialization
  • Support for MDTraj
  • Allow same input options as MCSampler (don't required WeightedMove)
  • Docstrings
  • Example
  • Tests

@dwhswenson dwhswenson marked this pull request as draft July 28, 2021 21:38
@codecov

codecov Bot commented Jul 28, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.63%. Comparing base (c67edf7) to head (e94fb60).
⚠️ Report is 466 commits behind head on master.

Files with missing lines Patch % Lines
openpathsampling/engines/openmm/mcengine.py 90.90% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
+ Coverage   81.54%   81.63%   +0.09%     
==========================================
  Files         140      141       +1     
  Lines       15400    15509     +109     
==========================================
+ Hits        12558    12661     +103     
- Misses       2842     2848       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dwhswenson

Copy link
Copy Markdown
Member Author

At this point, this seems to work. However, sampling single-atom Cartesian displacements, even for alanine dipeptide in vacuum, is SLOW. I think I need to improve the premise of the example before it is useful pedagogically without the context of this PR and #1040.

Performance is also not great. I haven't profiled it yet, but I wonder if we're going to and from the GPU with each MC trial. It looks to me like the OpenMMTools MCMC stuff was designed with hybrid Monte Carlo in mind, where one proposal creation would involve a significant chunk of work on the GPU.

Right now, I can't get an equilibrated trajectory because (1) trajectories are very long because single atom displacements require many frames for a transition; and (2) each frame seems to be quite slow compared to MD. (And of course (3) I need my computer for other things!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant