[WIP] Parallel committor with Dask#1001
Open
dwhswenson wants to merge 31 commits into
Open
Conversation
* switched from dill to cloudpickle due to conflicts (cloudpickle needed for dask) * made netcdfplus objects picklable (for immutable info) ... should check whether this is even necessary * moved setting the delayed interrupt the last moment, but that might be a performance risk for toy models
* GroFileEngine is now storable * snapshot_from_gro is in the `engines.gromacs` namespace
I don't know why this is necessary, but it seems to be. Without this, the process ends before dask starts running tasks.
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will include the first steps toward parallelization using Dask, including a rough implementation of a parallel committor. In principle, this code should be usable, but the long-term goal is to mix this with the hooks that will be part of the 1.5 release, instead of having a separate object for a parallel committor simulation.
This will sit in the
experimentalsubpackage, as I expect that we won't have a final interface that works with Dask until we also have a final implementation of RETIS using Dask.