Skip to content

Warning if fitted sklearn model being used #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 9 commits into from
Nov 3, 2020
Merged

Warning if fitted sklearn model being used #989

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d224845
sklearn model fit check
Neeratyoy Oct 28, 2020
409c6c0
Merge branch 'develop' into fix_968
Neeratyoy Oct 30, 2020
01a7c36
Reordering warning
Neeratyoy Oct 30, 2020
d08ad83
Update openml/extensions/sklearn/extension.py
mfeurer Nov 2, 2020
c72baee
Adding function to ext for checking model fit
Neeratyoy Nov 2, 2020
274506b
resolving merge conflicts
Neeratyoy Nov 2, 2020
acb8d66
Removing junk file
Neeratyoy Nov 2, 2020
3c3b3d8
Fixing sklearn version compatibility issue
Neeratyoy Nov 2, 2020
1e90133
Merge branch 'develop' into fix_968
Neeratyoy Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update openml/extensions/sklearn/extension.py 
Co-authored-by: PGijsbers <p.gijsbers@tue.nl>
  • Loading branch information
@mfeurer @PGijsbers
mfeurer and PGijsbers authored Nov 2, 2020
commit d08ad8317d2bc4c5f208cd5c065167761f58d324
2 changes: 1 addition & 1 deletion openml/extensions/sklearn/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1644,7 +1644,7 @@ def _prediction_to_probabilities(
try:
# check if model is fitted
# 'predict' internally calls sklearn.utils.validation.check_is_fitted for every
# model-specific attribute it excepts, thus offering a more robust check than
# model-specific attribute it expects, thus offering a more robust check than
# a generic simplified call of check_is_fitted(model_copy)
from sklearn.exceptions import NotFittedError

Expand Down