Skip to content

Added unit test to verify how the dataset object handles comparisons #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArlindKadra wants to merge 6 commits into from
Closed

Added unit test to verify how the dataset object handles comparisons #981

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
10a2bc3
Added unit test to verify how the dataset object handles comparisons
ArlindKadra Oct 29, 2020
4eb7d30
Merge branch 'develop' of https://github.com/openml/openml-python int…
ArlindKadra Oct 29, 2020
67e502e
Incorporating the develop changes and also updating doc/progress
ArlindKadra Oct 29, 2020
87b1d49
Removing comment as it serves no purpose
ArlindKadra Oct 29, 2020
d2bf82c
Addressing the comments from Matthias
ArlindKadra Oct 29, 2020
6f1e295
Removing non-existing attribute
ArlindKadra Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/progress.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Changelog

0.11.1
~~~~~~
* MAINT #577: Added unit test to verify how the dataset object handles comparisons.
* MAINT #671: Improved the performance of ``check_datasets_active`` by only querying the given list of datasets in contrast to querying all datasets. Modified the corresponding unit test.

0.11.0
Expand Down
4 changes: 4 additions & 0 deletions openml/datasets/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,10 @@ def __eq__(self, other):
"url",
"dataset",
Comment thread
ArlindKadra marked this conversation as resolved.
Outdated
"data_file",
"_dataset",
"data_pickle_file",
"data_feather_file",
"feather_attribute_file",
Comment on lines +299 to +302
Copy link
Copy Markdown
Collaborator

@PGijsbers PGijsbers Oct 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see these defined as a separate set (e.g. cache_fields), because these are not server fields.

}

# check that the keys are identical
Expand Down
5 changes: 5 additions & 0 deletions tests/test_datasets/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,11 @@ def test_get_data_corrupt_pickle(self):
self.assertIsInstance(xy, pd.DataFrame)
self.assertEqual(xy.shape, (150, 5))

def test_equality_comparison(self):
self.assertEqual(self.iris, self.iris)
self.assertNotEqual(self.iris, self.titanic)
self.assertNotEqual(self.titanic, 'Wrong_object')


class OpenMLDatasetTestOnTestServer(TestBase):
def setUp(self):
Expand Down