Skip to content

Better support for passthrough and drop in sklearn extension #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 6 commits into from
Sep 2, 2020
Merged

Better support for passthrough and drop in sklearn extension #943

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2294840
support passthrough and drop in sklearn extension when serialized to …
mfeurer Aug 27, 2020
9cf5d3a
make test work with sklearn==0.21
mfeurer Aug 31, 2020
8fc58fb
improve PR
mfeurer Aug 31, 2020
d9c96a7
Add additional unit tests
mfeurer Sep 1, 2020
1546a2f
fix test
mfeurer Sep 1, 2020
f710d47
incorporate feedback and generalize unit tests
mfeurer Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@mfeurer
mfeurer committed Sep 1, 2020
commit 1546a2fb228d08bc9ac6d8985b4f4c91c9f6338d
4 changes: 4 additions & 0 deletions tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,10 @@ def test_serialize_complex_flow(self):

self.assertEqual(new_model2_params, model_params)

@unittest.skipIf(
LooseVersion(sklearn.__version__) < "0.21",
reason="Pipeline till 0.20 doesn't support 'passthrough'",
)
def test_serialize_strings_as_pipeline_steps(self):
import sklearn.compose

Expand Down