Skip to content

[WIP] Add 781 #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 27 commits into from
Jul 2, 2020
Merged

[WIP] Add 781 #922

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ac68acb
Add Flake8 configuration
PGijsbers Jun 25, 2020
e7ef1f5
Add mypy configuration file
PGijsbers Jun 25, 2020
956c9e0
Pre-commit mypy flake8, add flake8 excludes
PGijsbers Jun 26, 2020
d8e4a28
Add Black to pre-commit
PGijsbers Jun 26, 2020
20fa286
Set max line length to 100
PGijsbers Jun 26, 2020
e48b9ed
Blacken code
PGijsbers Jun 26, 2020
e037d90
Add unit tests to flake8 and mypy pre-commit
PGijsbers Jun 26, 2020
04b6b3f
Use pre-commit for flake8, mypy and black checks
PGijsbers Jun 26, 2020
d46c72a
Update docs, add 'test' dependencies
PGijsbers Jun 26, 2020
6708821
Uninstall pytest-cov on appveyor ci
PGijsbers Jun 26, 2020
4c332a7
Add -y to uninstall
PGijsbers Jun 26, 2020
5a31f8e
Sphinx issue fix (#923)
Neeratyoy Jul 1, 2020
861600b
More robust handling of openml_url (#921)
joaquinvanschoren Jul 1, 2020
f49c3eb
format for black artifacts
PGijsbers Jul 2, 2020
7d8a6a3
Add Flake8 configuration
PGijsbers Jun 25, 2020
74cce61
Add mypy configuration file
PGijsbers Jun 25, 2020
ffffab4
Pre-commit mypy flake8, add flake8 excludes
PGijsbers Jun 26, 2020
f4aa438
Add Black to pre-commit
PGijsbers Jun 26, 2020
64002cd
Set max line length to 100
PGijsbers Jun 26, 2020
8a3c6ae
Blacken code
PGijsbers Jun 26, 2020
d4c6150
Add unit tests to flake8 and mypy pre-commit
PGijsbers Jun 26, 2020
3596c87
Use pre-commit for flake8, mypy and black checks
PGijsbers Jun 26, 2020
d77606e
Update docs, add 'test' dependencies
PGijsbers Jun 26, 2020
d9d25af
Uninstall pytest-cov on appveyor ci
PGijsbers Jun 26, 2020
477238c
Add -y to uninstall
PGijsbers Jun 26, 2020
6bfbb69
format for black artifacts
PGijsbers Jul 2, 2020
887810e
Resolve merge conflicts
PGijsbers Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More robust handling of openml_url (#921) 
I ran into issues when the openml server config is not exactly 'https://www.openml.org/api/v1/xml', e.g. I had 'https://www.openml.org/api/v1'.
I only noticed when getting a bad dataset url.

This edit makes the API more robust against how exactly the server URL is set in the config.
  • Loading branch information
@joaquinvanschoren
joaquinvanschoren authored Jul 1, 2020
commit 861600bc1677af694550ca11497fe4d3df60de6d
2 changes: 1 addition & 1 deletion openml/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def get_server_base_url() -> str:
=======
str
"""
return server[:-len('/api/v1/xml')]
return server.split("/api")[0]


apikey = _defaults['apikey']
Expand Down