Skip to content

More robust handling of openml_url #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 1 commit into from
Jul 1, 2020
Merged

More robust handling of openml_url #921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
More robust handling of openml_url 
I ran into issues when the openml server config is not exactly 'https://www.openml.org/api/v1/xml', e.g. I had 'https://www.openml.org/api/v1'.
I only noticed when getting a bad dataset url.

This edit makes the API more robust against how exactly the server URL is set in the config.
  • Loading branch information
@joaquinvanschoren
joaquinvanschoren authored Jun 24, 2020
commit 203f5dac28dd0d6d5b724f525b71d520cd7a72d6
2 changes: 1 addition & 1 deletion openml/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def get_server_base_url() -> str:
=======
str
"""
return server[:-len('/api/v1/xml')]
return server.split("/api")[0]


apikey = _defaults['apikey']
Expand Down