Skip to content

Removing support for deprecated pandas SparseDataFrame #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 12 commits into from
Mar 6, 2020
Merged

Removing support for deprecated pandas SparseDataFrame #897

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
419aba3
Removing support for pandas SparseDataFrame
Neeratyoy Feb 11, 2020
0b16425
Fixing rebase loss
Neeratyoy Feb 17, 2020
9d6054a
Reiterating with Matthias' changes
Neeratyoy Feb 21, 2020
97b5f46
Merge branch 'develop' into fix_836
Neeratyoy Feb 21, 2020
bd4a512
Rolling back setup
Neeratyoy Feb 21, 2020
1a98e92
Merge branch 'fix_836' of https://github.com/openml/openml-python int…
Neeratyoy Feb 21, 2020
090270f
Fixing PEP8
Neeratyoy Feb 23, 2020
aa8fdcf
Changing check to detect sparse dataframes
Neeratyoy Feb 28, 2020
1b45ec0
Fixing edge case to handle server side arff issue
Neeratyoy Mar 2, 2020
6d96519
Removing stray comment
Neeratyoy Mar 3, 2020
398eafb
Failing test case fix
Neeratyoy Mar 3, 2020
dc8d8aa
Removing stray comment
Neeratyoy Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Failing test case fix
  • Loading branch information
@Neeratyoy
Neeratyoy committed Mar 3, 2020
commit 398eafb7f48b9904d27a45200f6ae3f65a54d8f5
6 changes: 5 additions & 1 deletion examples/30_extended/create_upload_tutorial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,12 @@
# Dataset is a pandas sparse dataframe
Copy link
Copy Markdown
Collaborator

@mfeurer mfeurer Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please update this header to reflect the fact that pandas doesn't have this class any more.

# ====================================

# sparse_data = coo_matrix((
Copy link
Copy Markdown
Collaborator

@mfeurer mfeurer Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not keep old code.

# [0.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0],
# ([0, 1, 1, 2, 2, 3, 3], [0, 1, 2, 0, 2, 0, 1])
# ))
sparse_data = coo_matrix((
[0.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0],
[1.0, 0.0, 1.0, 1.0, 1.0, 1.0, 1.0],
([0, 1, 1, 2, 2, 3, 3], [0, 1, 2, 0, 2, 0, 1])
))
column_names = ['input1', 'input2', 'y']
Expand Down