Skip to content

store uint8 data in uint8 not float #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amueller wants to merge 4 commits into from
Closed

store uint8 data in uint8 not float #892

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
164173a
store uint8 data in uint8 not float
amueller Dec 3, 2019
3f0fac1
don't be strict on boundaries, mnist has constant features
amueller Dec 3, 2019
6dd7581
add try block in case of missing data, add test
amueller Dec 3, 2019
3225588
fix expected dtypes
amueller Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't be strict on boundaries, mnist has constant features
  • Loading branch information
@amueller
amueller committed Dec 3, 2019
commit 3f0fac11fbc1d6a5a3bb7ec63b8dbe1f51691baf
2 changes: 1 addition & 1 deletion openml/datasets/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def _parse_data_from_arff(
elif attribute_dtype[column_name] in ('floating',
'integer'):
X_col = X[column_name]
if X_col.min() == 0 and X_col.max() == 255:
if X_col.min() >= 0 and X_col.max() <= 255:
X_col_uint = X_col.astype('uint8')
if (X_col == X_col_uint).all():
col.append(X_col_uint)
Expand Down