Skip to content

To handle non-actionable steps in sklearn #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 7 commits into from
Nov 18, 2019
Merged

To handle non-actionable steps in sklearn #866

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
78b163e
Initial changes to handle reproducible example from the issue
Neeratyoy Nov 6, 2019
4875dba
Making tentative changes; Need to test deserialization
Neeratyoy Nov 12, 2019
0234d19
Fixing deserialization when empty steps in sklearn model
Neeratyoy Nov 12, 2019
cbf0d6a
Fixing flake issues, failing test cases
Neeratyoy Nov 13, 2019
7768ca3
Fixing test cases
Neeratyoy Nov 13, 2019
35d3c34
Dropping support for 'None' as sklearn estimator
Neeratyoy Nov 15, 2019
3b03d15
Adding test case for None estimator
Neeratyoy Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing test cases
  • Loading branch information
@Neeratyoy
Neeratyoy committed Nov 13, 2019
commit 7768ca3c2d87549fbb10503f9bb3fd6a557a49d6
8 changes: 4 additions & 4 deletions tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import sklearn.preprocessing
import sklearn.tree
import sklearn.cluster
from sklearn.impute import SimpleImputer
from sklearn.pipeline import make_pipeline
from sklearn.preprocessing import OneHotEncoder, StandardScaler

Expand All @@ -38,7 +37,7 @@
from openml.flows import OpenMLFlow
from openml.flows.functions import assert_flows_equal
from openml.runs.trace import OpenMLRunTrace
from openml.testing import TestBase
from openml.testing import TestBase, SimpleImputer


this_directory = os.path.dirname(os.path.abspath(__file__))
Expand Down Expand Up @@ -1780,8 +1779,9 @@ def test_trim_flow_name(self):
self.assertEqual("weka.IsolationForest",
SklearnExtension.trim_flow_name("weka.IsolationForest"))

@unittest.skipIf(LooseVersion(sklearn.__version__) < "0.20",
reason="SimpleImputer, ColumnTransformer available only after 0.19")
@unittest.skipIf(LooseVersion(sklearn.__version__) < "0.21",
reason="SimpleImputer, ColumnTransformer available only after 0.19 and "
"Pipeline till 0.20 doesn't support indexing and 'passthrough'")
def test_run_on_model_with_empty_steps(self):
from sklearn.compose import ColumnTransformer
# testing 'drop', 'passthrough', None as non-actionable sklearn estimators
Expand Down