Skip to content

Add #737 #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 9 commits into from
Sep 2, 2019
Merged

Add #737 #772

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fcc2049
changes in list_evaluations_setups
sahithyaravi Aug 21, 2019
1921ed9
fixed some flake8 erros
sahithyaravi Aug 21, 2019
39f1627
PEP8 errors
sahithyaravi Aug 21, 2019
55be331
shorten line
sahithyaravi Aug 21, 2019
00d59f2
change equals check to isin
sahithyaravi Aug 21, 2019
5ea8904
review comments
sahithyaravi Aug 28, 2019
e317894
pep8 and mypy errors
sahithyaravi Aug 28, 2019
f825d59
change comment
sahithyaravi Aug 29, 2019
454f297
fix example fetch_evaluations
sahithyaravi Sep 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pep8 and mypy errors
  • Loading branch information
@sahithyaravi
sahithyaravi committed Aug 28, 2019
commit e317894bc6ad214c756fdf57bd99ec9ade96535a
4 changes: 2 additions & 2 deletions openml/evaluations/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,8 @@ def list_evaluations_setups(
df = pd.merge(evals, setups, on='setup_id', how='left')

if parameters_in_separate_columns:
df = pd.concat([df.drop('parameters', axis=1), df['parameters'].apply(pd.Series)],
axis=1)
df = pd.concat([df.drop('parameters', axis=1),
df['parameters'].apply(pd.Series)], axis=1)

if output_format == 'dataframe':
return df
Expand Down
2 changes: 1 addition & 1 deletion tests/test_evaluations/test_evaluation_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def _check_list_evaluation_setups(self, size, **kwargs):
list1 = [param['oml:value'] for param in params]
list2 = list(row['parameters'].values())
# check if all values are equal
self.assertSequenceEqual(list1, list2)
self.assertSequenceEqual(sorted(list1), sorted(list2))
return evals_setups

def test_evaluation_list_filter_task(self):
Expand Down