Skip to content

[MNT] Fix race condition in OpenMLSplit tests during parallel execution #1641 #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codervinitjangir wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[MNT] Fix race condition in OpenMLSplit tests during parallel execution #1641 #1694

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
447aff1
fix: race condition in OpenMLSplitTest when running tests in parallel…
codervinitjangir Mar 1, 2026
b29157d
Merge branch 'main' into fix/race-condition-split
codervinitjangir Mar 5, 2026
6d0b51d
Apply maintainer cleanup suggestions
codervinitjangir Mar 5, 2026
981213d
Fix race condition setup by preserving temp dir and restoring eq test
codervinitjangir Mar 5, 2026
d962e74
Revert setUp to original main branch state and adapt tearDown
codervinitjangir Mar 5, 2026
ebe11c3
Revert setUp to match upstream main, simplify tearDown as requested
codervinitjangir Mar 5, 2026
f6bac1f
Merge branch 'main' into fix/race-condition-split
codervinitjangir Mar 7, 2026
758577e
Merge branch 'main' into fix/race-condition-split
codervinitjangir Mar 10, 2026
7f00928
Merge branch 'main' into fix/race-condition-split
PGijsbers Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert setUp to original main branch state and adapt tearDown
  • Loading branch information
@codervinitjangir
codervinitjangir committed Mar 5, 2026
commit d962e74f0223f67baeff5b7f0ba6ba725ae0d8c4
11 changes: 6 additions & 5 deletions tests/test_tasks/test_split.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ class OpenMLSplitTest(TestBase):

def setUp(self):
Copy link
Copy Markdown
Collaborator

@geetu040 geetu040 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change anything here, keep it as it was

Copy link
Copy Markdown
Collaborator

@geetu040 geetu040 Mar 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1694 (comment) is still unresolved

super().setUp()
self._temp_dir = tempfile.TemporaryDirectory()
self.test_dir = tempfile.mkdtemp()
__file__ = inspect.getfile(OpenMLSplitTest)
self.directory = os.path.dirname(__file__)
# This is for dataset
source_arff = (
original_arff_filepath = (
Path(self.directory).parent
/ "files"
/ "org"
Expand All @@ -35,12 +35,13 @@ def setUp(self):
/ "1882"
/ "datasplits.arff"
)
self.arff_filepath = Path(self._temp_dir.name) / "datasplits.arff"
shutil.copy(source_arff, self.arff_filepath)
self.arff_filepath = Path(self.test_dir) / "datasplits.arff"
shutil.copy(original_arff_filepath, self.arff_filepath)
self.pd_filename = self.arff_filepath.with_suffix(".pkl.py3")

def tearDown(self):
self._temp_dir.cleanup()
shutil.rmtree(self.test_dir)
super().tearDown()
Copy link
Copy Markdown
Collaborator

@geetu040 geetu040 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
super().tearDown()
def tearDown(self):
self._temp_dir.cleanup()

Copy link
Copy Markdown
Collaborator

@geetu040 geetu040 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tearDown can simply be written as:

    def tearDown(self):
        self._temp_dir.cleanup()


def test_eq(self):
split = OpenMLSplit._from_arff_file(self.arff_filepath)
Expand Down