Skip to content

[MNT] Fix race condition in OpenMLSplit._from_arff_file #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fkiraly merged 6 commits into from
Mar 3, 2026
Merged

[MNT] Fix race condition in OpenMLSplit._from_arff_file #1656

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35c6b2f
[MNT] Fix race condition in `OpenMLSplit._from_arff_file`
omkar-334 Feb 18, 2026
ce5aad5
Merge branch 'main' into fixrace
omkar-334 Feb 18, 2026
1823407
Merge branch 'main' into fixrace
omkar-334 Feb 20, 2026
3889028
use `TemporaryDirectory` and cleanup
omkar-334 Feb 20, 2026
5f49723
Update test_split.py
omkar-334 Mar 1, 2026
9d55bfc
Merge branch 'main' into pr/1656
fkiraly Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions tests/test_tasks/test_split.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

import inspect
import os
import shutil
import tempfile
from pathlib import Path

import numpy as np
Expand All @@ -18,8 +20,7 @@ class OpenMLSplitTest(TestBase):
def setUp(self):
__file__ = inspect.getfile(OpenMLSplitTest)
self.directory = os.path.dirname(__file__)
# This is for dataset
self.arff_filepath = (
source_arff = (
Path(self.directory).parent
/ "files"
/ "org"
Expand All @@ -29,13 +30,15 @@ def setUp(self):
/ "1882"
/ "datasplits.arff"
)
self.pd_filename = self.arff_filepath.with_suffix(".pkl.py3")
# Use temporary directory to avoid conflicts with other tests
self.temp_dir = Path(tempfile.mkdtemp())
Comment thread
omkar-334 marked this conversation as resolved.
Outdated
self.arff_filepath = self.temp_dir / "datasplits.arff"
shutil.copy2(source_arff, self.arff_filepath)
Comment thread
omkar-334 marked this conversation as resolved.
Outdated

def tearDown(self):
try:
os.remove(self.pd_filename)
except (OSError, FileNotFoundError):
# Replaced bare except. Not sure why these exceptions are acceptable.
shutil.rmtree(self.temp_dir, ignore_errors=True)
except OSError:
pass
Comment on lines 42 to 45
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The try/except block wrapping shutil.rmtree with ignore_errors=True is redundant. When ignore_errors=True is set, shutil.rmtree already suppresses all exceptions internally, making the outer try/except OSError unnecessary. Consider simplifying to just: shutil.rmtree(self.temp_dir, ignore_errors=True)

Copilot uses AI. Check for mistakes.

def test_eq(self):
Expand Down