Skip to content

[BUG] race condition in OpenMLSplitTest when running tests in parallel #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fkiraly merged 4 commits into from
Mar 3, 2026
+10 −3
Merged

[BUG] race condition in OpenMLSplitTest when running tests in parallel #1643

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0fec17c
fix: race condition in OpenMLSplitTest when running tests in parallel
Alm0stSurely Feb 18, 2026
8910a81
refactor: use TemporaryDirectory instead of mkdtemp
Alm0stSurely Feb 20, 2026
6fa7e93
Merge branch 'main' into fix/race-condition-test-split
Alm0stSurely Feb 20, 2026
46685ba
Merge branch 'main' into fix/race-condition-test-split
fkiraly Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: use TemporaryDirectory instead of mkdtemp 
Replace tempfile.mkdtemp() with tempfile.TemporaryDirectory() for
safer automatic cleanup, as suggested by @geetu040.
  • Loading branch information
@Alm0stSurely
Alm0stSurely committed Feb 20, 2026
commit 8910a81db855948485a38da49b1868748f506ba0
6 changes: 3 additions & 3 deletions tests/test_tasks/test_split.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ def setUp(self):
)
# Use a unique temp directory for each test to avoid race conditions
# when running tests in parallel (see issue #1641)
self._temp_dir = tempfile.mkdtemp()
self.arff_filepath = Path(self._temp_dir) / "datasplits.arff"
self._temp_dir = tempfile.TemporaryDirectory()
self.arff_filepath = Path(self._temp_dir.name) / "datasplits.arff"
shutil.copy(source_arff, self.arff_filepath)
self.pd_filename = self.arff_filepath.with_suffix(".pkl.py3")

def tearDown(self):
# Clean up the entire temp directory
try:
shutil.rmtree(self._temp_dir)
self._temp_dir.cleanup()
except (OSError, FileNotFoundError):
pass
Comment thread
fkiraly marked this conversation as resolved.

Expand Down