Skip to content

Automatically connect to production server based on mark #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LennartPurucker merged 11 commits into from
Jun 18, 2025
Merged

Automatically connect to production server based on mark #1411

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9034ac5
Automatically connect to production server based on mark
PGijsbers Jun 18, 2025
09e6f8b
Don't reconfigure server on setup/teardown, handled by fixture
PGijsbers Jun 18, 2025
32b1320
Execute on prod and test for ubuntu
PGijsbers Jun 18, 2025
4287c24
Switch order
PGijsbers Jun 18, 2025
ad89be4
move markers to end of invocation
PGijsbers Jun 18, 2025
b7624ef
revert change
PGijsbers Jun 18, 2025
9f243bd
Add quotes to invocation
PGijsbers Jun 18, 2025
5279ab7
try different way to preserve the quotes
PGijsbers Jun 18, 2025
44c2bd5
Dont use start/stop, adjust for new defaults
PGijsbers Jun 18, 2025
91f3d52
Use correct estimation procudure id
PGijsbers Jun 18, 2025
c92c672
[no ci] add test marker
PGijsbers Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Dont use start/stop, adjust for new defaults
  • Loading branch information
@PGijsbers
PGijsbers committed Jun 18, 2025
commit 44c2bd575fd5d328997cc1da978630163be6ea09
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
if [ ${{ matrix.code-cov }} ]; then codecov='--cov=openml --long --cov-report=xml'; fi
# Most of the time, running only the scikit-learn tests is sufficient
if [ ${{ matrix.sklearn-only }} = 'true' ]; then marks='sklearn and not production'; else marks='not production'; fi
echo pytest -n 4 --durations=20 --dist load -sv $codecov -o log_cli=true $marks
echo pytest -n 4 --durations=20 --dist load -sv $codecov -o log_cli=true -m "$marks"
pytest -n 4 --durations=20 --dist load -sv $codecov -o log_cli=true -m "$marks"
- name: Run tests on Ubuntu Production
if: matrix.os == 'ubuntu-latest'
Expand Down
3 changes: 2 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,8 @@ def with_server(request):
openml.config.server = "https://www.openml.org/api/v1/xml"
yield
return
openml.config.start_using_configuration_for_example()
openml.config.server = "https://test.openml.org/api/v1/xml"
openml.config.apikey = "c0c42819af31e706efe1f4b88c23c6c1"
yield


Expand Down
3 changes: 2 additions & 1 deletion tests/test_datasets/test_dataset_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,7 +1951,8 @@ def test_get_dataset_parquet(requests_mock, test_files_directory):
content_file = (
test_files_directory / "mock_responses" / "datasets" / "data_description_61.xml"
)
requests_mock.get("https://www.openml.org/api/v1/xml/data/61", text=content_file.read_text())
# While the mocked example is from production, unit tests by default connect to the test server.
requests_mock.get("https://test.openml.org/api/v1/xml/data/61", text=content_file.read_text())
dataset = openml.datasets.get_dataset(61, download_data=True)
assert dataset._parquet_url is not None
assert dataset.parquet_file is not None
Expand Down
Loading