Skip to content

fix: avoid stripping whitespaces for feature names #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddiebergman merged 3 commits into from
Oct 16, 2024
Merged

fix: avoid stripping whitespaces for feature names #1368

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6c7400
fix: minimal invasive change to avoid stripping whitespaces for featu…
LennartPurucker Oct 16, 2024
edceced
fix: roll back change to work with older and newer xmltodict versions
LennartPurucker Oct 16, 2024
e44e8bf
add: test for whitespaces in features xml
LennartPurucker Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: roll back change to work with older and newer xmltodict versions
  • Loading branch information
@LennartPurucker
LennartPurucker committed Oct 16, 2024
commit edcecedf72768af9f3e5353ef4ac305ac2ad16d9
8 changes: 1 addition & 7 deletions openml/study/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def get_study(
return study


def _get_study(id_: int | str, entity_type: str) -> BaseStudy: # noqa: C901
def _get_study(id_: int | str, entity_type: str) -> BaseStudy:
xml_string = openml._api_calls._perform_api_call(f"study/{id_}", "get")
force_list_tags = (
"oml:data_id",
Expand All @@ -93,12 +93,6 @@ def _get_study(id_: int | str, entity_type: str) -> BaseStudy: # noqa: C901
alias = result_dict.get("oml:alias", None)
main_entity_type = result_dict["oml:main_entity_type"]

# Parses edge cases where the server returns a string with a newline character for empty values.
none_value_indicator = "\n "
for key in result_dict:
if result_dict[key] == none_value_indicator:
result_dict[key] = None

if entity_type != main_entity_type:
raise ValueError(
f"Unexpected entity type '{main_entity_type}' reported by the server"
Expand Down