Skip to content

Pass kwargs through task to get_dataset #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 3 commits into from
Sep 29, 2024
Merged

Pass kwargs through task to get_dataset #1345

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f36b07
Pass kwargs through task to ```get_dataset```
knyazer Aug 23, 2024
ba8eef4
docs: explain that ```task.get_dataset``` passes kwargs
knyazer Sep 17, 2024
1f29586
Update openml/tasks/task.py
PGijsbers Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: explain that task.get_dataset passes kwargs
  • Loading branch information
@knyazer
knyazer committed Sep 17, 2024
commit ba8eef41b37987f60f92e7070e4dd3c32a0caaaa
7 changes: 5 additions & 2 deletions openml/tasks/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,11 @@ def _get_repr_body_fields(self) -> Sequence[tuple[str, str | int | list[str]]]:
]
return [(key, fields[key]) for key in order if key in fields]

def get_dataset(self, **kwargs) -> datasets.OpenMLDataset:
"""Download dataset associated with task."""
def get_dataset(self, /, **kwargs) -> datasets.OpenMLDataset:
Comment thread
PGijsbers marked this conversation as resolved.
Outdated
"""Download dataset associated with task.

Accepts the same keyword arguments as the `openml.datasets.get_dataset`.
"""
return datasets.get_dataset(self.dataset_id, **kwargs)

def get_train_test_split_indices(
Expand Down