Skip to content

read file in read mode #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 4 commits into from
May 15, 2024
Merged

read file in read mode #1338

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a260f8
read file in read mode
BrunoBelucci May 12, 2024
2912e1a
cast parameters to expected types
BrunoBelucci May 12, 2024
dbffcac
Following PGijsbers proposal to ensure that avoid_duplicate_runs is a…
BrunoBelucci May 13, 2024
4a9b568
Add a test, move parsing of avoid_duplicate_runs
PGijsbers May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions openml/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,11 @@ def _setup(config: _Config | None = None) -> None:
if config is None:
config = _parse_config(config_file)

avoid_duplicate_runs = config.get("avoid_duplicate_runs", False)
avoid_duplicate_runs = bool(config.get("avoid_duplicate_runs", False))
Comment thread
BrunoBelucci marked this conversation as resolved.
Outdated
apikey = config["apikey"]
server = config["server"]
short_cache_dir = config["cachedir"]
n_retries = config["connection_n_retries"]
short_cache_dir = Path(config["cachedir"])
n_retries = int(config["connection_n_retries"])

set_retry_policy(config["retry_policy"], n_retries)

Expand Down Expand Up @@ -319,7 +319,7 @@ def _parse_config(config_file: str | Path) -> _Config:
config_file_ = StringIO()
config_file_.write("[FAKE_SECTION]\n")
try:
with config_file.open("w") as fh:
with config_file.open("r") as fh:
for line in fh:
config_file_.write(line)
except FileNotFoundError:
Expand Down