Skip to content

Linting Everything - Fix All mypy and ruff Errors #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LennartPurucker merged 40 commits into from
Jan 9, 2024
Merged

Linting Everything - Fix All mypy and ruff Errors #1307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
846a539
style: Fix linting split.py
eddiebergman Jan 8, 2024
053b053
typing: Fix mypy errors split.py
eddiebergman Jan 8, 2024
48d9471
typing: data_feature
eddiebergman Jan 8, 2024
7dbc9b6
typing: trace
eddiebergman Jan 8, 2024
2712c71
more linting fixes
LennartPurucker Jan 8, 2024
e3e432e
Merge branch 'fix_linter_lennart' of https://github.com/openml/openml…
LennartPurucker Jan 8, 2024
69f033e
typing: finish up trace
eddiebergman Jan 8, 2024
798cb8e
typing: config.py
eddiebergman Jan 8, 2024
5fbb36a
typing: More fixes on config.py
eddiebergman Jan 8, 2024
c88f8f4
typing: setup.py
eddiebergman Jan 8, 2024
f911c30
finalize runs linting
LennartPurucker Jan 8, 2024
92d9b26
Merge branch 'fix_linter_lennart' of https://github.com/openml/openml…
LennartPurucker Jan 8, 2024
38bcd5e
typing: evaluation.py
eddiebergman Jan 8, 2024
869f9c4
typing: setup
eddiebergman Jan 8, 2024
abc6117
ruff fixes across different files and mypy fixes for run files
LennartPurucker Jan 8, 2024
54aca64
Merge branch 'fix_linter_lennart' of https://github.com/openml/openml…
LennartPurucker Jan 8, 2024
f6c2ae5
typing: _api_calls
eddiebergman Jan 8, 2024
960afa1
adjust setup files' linting and minor ruff changes
LennartPurucker Jan 8, 2024
bea95cc
Merge branch 'fix_linter_lennart' of https://github.com/openml/openml…
LennartPurucker Jan 8, 2024
5ea4287
typing: utils
eddiebergman Jan 8, 2024
cffd7ed
late night push
LennartPurucker Jan 8, 2024
6d3ae4a
Merge branch 'fix_linter_lennart' of https://github.com/openml/openml…
LennartPurucker Jan 8, 2024
bef753e
typing: utils.py
eddiebergman Jan 8, 2024
1df08b5
typing: tip tap tippity
eddiebergman Jan 9, 2024
d4f79f8
typing: mypy 78, ruff ~200
eddiebergman Jan 9, 2024
cecc746
refactor output format name and minor linting stuff
LennartPurucker Jan 9, 2024
3804220
other: midway merge
eddiebergman Jan 9, 2024
57db7f0
merge
eddiebergman Jan 9, 2024
c9c96b1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 9, 2024
bb0cdd1
typing: I'm runnign out of good messages
eddiebergman Jan 9, 2024
e38fdd1
Merge branch 'fix_linter_lennart' of github.com:openml/openml-python …
eddiebergman Jan 9, 2024
dcc60f5
typing: datasets
eddiebergman Jan 9, 2024
a19bc26
leinting for flows and some ruff changes
LennartPurucker Jan 9, 2024
93b83eb
Merge branch 'fix_linter_lennart' of https://github.com/openml/openml…
LennartPurucker Jan 9, 2024
9174f20
no more mypy errors
LennartPurucker Jan 9, 2024
a87109a
ruff runs and setups
LennartPurucker Jan 9, 2024
10a2f5e
typing: Finish off mypy and ruff errors
eddiebergman Jan 9, 2024
66e3c97
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 9, 2024
66a3ab1
style: File wide ignores of PLR0913
eddiebergman Jan 9, 2024
290578c
Merge branch 'fix_linter_lennart' of github.com:openml/openml-python …
eddiebergman Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Jan 9, 2024
commit 66e3c97cc7fe5a54bb5a314b326dbfb4d87604ff
6 changes: 3 additions & 3 deletions openml/datasets/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def list_qualities() -> list[str]:


@overload
def list_datasets( # noqa: PLR0913
def list_datasets(
data_id: list[int] | None = ...,
offset: int | None = ...,
size: int | None = ...,
Expand All @@ -89,7 +89,7 @@ def list_datasets( # noqa: PLR0913


@overload
def list_datasets( # noqa: PLR0913
def list_datasets(
data_id: list[int] | None,
offset: int | None,
size: int | None,
Expand All @@ -102,7 +102,7 @@ def list_datasets( # noqa: PLR0913


@overload
def list_datasets( # noqa: PLR0913
def list_datasets(
data_id: list[int] | None = ...,
offset: int | None = ...,
size: int | None = ...,
Expand Down
4 changes: 2 additions & 2 deletions openml/evaluations/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@


@overload
def list_evaluations( # noqa: PLR0913
def list_evaluations(
function: str,
offset: int | None = ...,
size: int | None = ...,
Expand All @@ -36,7 +36,7 @@ def list_evaluations( # noqa: PLR0913


@overload
def list_evaluations( # noqa: PLR0913
def list_evaluations(
function: str,
offset: int | None = ...,
size: int | None = ...,
Expand Down
4 changes: 2 additions & 2 deletions openml/study/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def list_suites(


@overload
def list_studies( # noqa: PLR0913
def list_studies(
offset: int | None = ...,
size: int | None = ...,
status: str | None = ...,
Expand All @@ -542,7 +542,7 @@ def list_studies( # noqa: PLR0913


@overload
def list_studies( # noqa: PLR0913
def list_studies(
offset: int | None = ...,
size: int | None = ...,
status: str | None = ...,
Expand Down