Skip to content

fix: carefully replaced minio_url with parquet_url #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 6 commits into from
Aug 17, 2023
Merged

fix: carefully replaced minio_url with parquet_url #1280

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c5d5da
carefully replaced minio with parquet
varshneydevansh Aug 10, 2023
04151a0
fix: corrected some mistakes
varshneydevansh Aug 11, 2023
5e97ad0
fix: restored the instances of minio
varshneydevansh Aug 11, 2023
a5f61c4
fix: updated the documentation
varshneydevansh Aug 15, 2023
f0fa658
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 15, 2023
1c7c614
Add #1280
PGijsbers Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: restored the instances of minio
  • Loading branch information
@varshneydevansh
varshneydevansh committed Aug 11, 2023
commit 5e97ad008390b73576d9a5a04f7d02e65be88317
4 changes: 2 additions & 2 deletions tests/test_datasets/test_dataset_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,8 +1412,8 @@ def test_get_dataset_cache_format_pickle(self):

def test_get_dataset_cache_format_feather(self):
# This test crashed due to using the parquet file by default, which is downloaded
# from parquet. However, there is a mismatch between OpenML test server and parquet IDs.
# The parquet file on parquet with ID 128 is not the iris dataset from the test server.
# from minio. However, there is a mismatch between OpenML test server and minio IDs.
# The parquet file on minio with ID 128 is not the iris dataset from the test server.
dataset = openml.datasets.get_dataset(128, cache_format="feather")
# Workaround
dataset._parquet_url = None
Expand Down