Skip to content

Docker enhancement #1277 #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 10 commits into from
Aug 15, 2023
Merged

Docker enhancement #1277 #1278

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7f63092
Add multiple build platforms
PGijsbers Jul 25, 2023
73a7940
Automatically update Dockerhub description
PGijsbers Jul 27, 2023
998e641
Launch Python instead of Bash by default
PGijsbers Jul 27, 2023
d57cd5d
Change `omlp` directory name to less cryptic `openml`
PGijsbers Jul 27, 2023
7709348
Change directory to `openml` for running purpose of running script
PGijsbers Jul 27, 2023
7412f05
Update readme to reflect updates (python by default, rename dirs)
PGijsbers Jul 27, 2023
baa754f
Add branch/code for doc and test examples as they are required
PGijsbers Jul 27, 2023
21161b6
Ship docker images with readme
PGijsbers Jul 27, 2023
e279c2b
Only update readme on release, also try build docker on PR
PGijsbers Jul 27, 2023
1c9bda7
Update the toc descriptions
PGijsbers Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change omlp directory name to less cryptic openml
  • Loading branch information
@PGijsbers
PGijsbers committed Jul 27, 2023
commit d57cd5d8adc6cd7771bf5be625f0fc7d3e3f53bb
4 changes: 2 additions & 2 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# Useful building docs or running unix tests from a Windows host.
FROM python:3.10

RUN git clone https://github.com/openml/openml-python.git omlp
WORKDIR omlp
RUN git clone https://github.com/openml/openml-python.git openml
WORKDIR openml
RUN python -m venv venv
RUN venv/bin/pip install wheel setuptools
RUN venv/bin/pip install -e .[test,examples,docs,examples_unix]
Expand Down
12 changes: 6 additions & 6 deletions docker/startup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# The test or doc build is executed on this branch.

if [[ ! ( $1 = "doc" || $1 = "test" ) ]]; then
source /omlp/venv/bin/activate
source /openml/venv/bin/activate
python "$@"
exit 0
fi
Expand All @@ -35,8 +35,8 @@ if [ "$1" == "doc" ] && [ -n "$2" ] && ! [ -d "/output" ]; then
fi

if [ -n "$2" ]; then
# if a branch is provided, we will pull it into the `omlp` local repository that was created with the image.
cd omlp
# if a branch is provided, we will pull it into the `openml` local repository that was created with the image.
cd openml
if [[ $2 == *#* ]]; then
# If a branch is specified on a fork (with NAME#BRANCH format), we have to construct the url before pulling
# We add a trailing '#' delimiter so the second element doesn't get the trailing newline from <<<
Expand All @@ -55,12 +55,12 @@ if [ -n "$2" ]; then
exit 1
fi
git pull
code_dir="/omlp"
code_dir="/openml"
else
code_dir="/code"
fi

source /omlp/venv/bin/activate
source /openml/venv/bin/activate
cd $code_dir
# The most recent ``main`` is already installed, but we want to update any outdated dependencies
pip install -e .[test,examples,docs,examples_unix]
Expand All @@ -74,6 +74,6 @@ if [ "$1" == "doc" ]; then
make html
make linkcheck
if [ -d "/output" ]; then
cp -r /omlp/doc/build /output
cp -r /openml/doc/build /output
fi
fi