Skip to content

Make test robuster to server state, avoid attaching attached runs #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 1 commit into from
Jun 16, 2023
Merged

Make test robuster to server state, avoid attaching attached runs #1263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make test robuster to server state, avoid attaching attached runs 
It is not allowed to attach a run to a study which is already
associated with the study. This leads to a misleading error:
`1045: Problem attaching entities. Please ensure to only attach entities that exist - None`
  • Loading branch information
@PGijsbers
PGijsbers committed Jun 16, 2023
commit 86bf4eaba279d89d236bc389e0358a52e9d9be5b
11 changes: 6 additions & 5 deletions tests/test_study/test_study_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,18 +187,19 @@ def test_publish_study(self):
)
self.assertSetEqual(set(run_ids), set(study_downloaded.runs))

# attach more runs
run_list_additional = openml.runs.list_runs(size=10, offset=10)
openml.study.attach_to_study(study.id, list(run_list_additional.keys()))
# attach more runs, since we fetch 11 here, at least one is non-overlapping
run_list_additional = openml.runs.list_runs(size=11, offset=10)
run_list_additional = set(run_list_additional) - set(run_ids)
openml.study.attach_to_study(study.id, list(run_list_additional))
study_downloaded = openml.study.get_study(study.id)
# verify again
all_run_ids = set(run_list_additional.keys()) | set(run_list.keys())
all_run_ids = run_list_additional | set(run_list.keys())
self.assertSetEqual(set(study_downloaded.runs), all_run_ids)

# test detach function
openml.study.detach_from_study(study.id, list(run_list.keys()))
study_downloaded = openml.study.get_study(study.id)
self.assertSetEqual(set(study_downloaded.runs), set(run_list_additional.keys()))
self.assertSetEqual(set(study_downloaded.runs), run_list_additional)

# test status update function
openml.study.update_study_status(study.id, "deactivated")
Expand Down