Skip to content

Prepare release 0.14 #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 6 commits into from
Jul 3, 2023
Merged

Prepare release 0.14 #1262

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31c0df8
Bump version number and add changelog
mfeurer Jun 16, 2023
2b55b39
Incorporate feedback from Pieter
mfeurer Jun 16, 2023
3ef4c06
Fix unit test
mfeurer Jun 16, 2023
8ff9831
Make assert less strict
mfeurer Jun 16, 2023
c738a3e
Update release notes
mfeurer Jun 19, 2023
2ea523c
Fix indent
mfeurer Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unit test
  • Loading branch information
@mfeurer
mfeurer committed Jun 16, 2023
commit 3ef4c06949f8d5c550c028189a31ce4467eb1631
16 changes: 10 additions & 6 deletions tests/test_utils/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,21 @@ def test_list_all(self):

def test_list_all_with_multiple_batches(self):
res = openml.utils._list_all(
listing_call=openml.tasks.functions._list_tasks, output_format="dict", batch_size=2000
listing_call=openml.tasks.functions._list_tasks, output_format="dict", batch_size=1050
)
# Verify that test server state is still valid for this test to work as intended
# -> If the number of results is less than 2000, the test can not test the
# batching operation.
assert len(res) > 2000
openml.utils._list_all(
# -> If the number of results is less than 1050, the test can not test the
# batching operation. By having more than 1050 results we know that batching
# was triggered. 1050 appears to be a number of tasks that is available on a fresh
# test server.
assert len(res) > 1050
res2 = openml.utils._list_all(
listing_call=openml.tasks.functions._list_tasks,
output_format="dataframe",
batch_size=2000,
batch_size=1050,
)
# It might be possible that someone added a new task in the meantime
assert len(res) <= len(res2)

@unittest.mock.patch("openml._api_calls._perform_api_call", side_effect=mocked_perform_api_call)
def test_list_all_few_results_available(self, _perform_api_call):
Expand Down