Skip to content

Deprecate output_format='dict' #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 21 commits into from
Jun 16, 2023
Merged

Deprecate output_format='dict' #1258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
30dd55f
Add deprecation warning for retrieving dict
PGijsbers Jun 15, 2023
b502312
Refactor check_datasets_active to work with dataframe
PGijsbers Jun 15, 2023
357bb7d
Update unit tests to use list_datasets with output_format dataframe
PGijsbers Jun 15, 2023
29bbb57
Move list_datasets test to proper file
PGijsbers Jun 15, 2023
464e5dd
Remove list_datasets test, duplicate in test_datasets_functions
PGijsbers Jun 15, 2023
aaad25f
Update list_flows calls to use output_format='dataframe'
PGijsbers Jun 15, 2023
cf9dd7b
Update list_runs calls to require dataframe output
PGijsbers Jun 15, 2023
13f2fb5
Update list_setup calls for deprecation
PGijsbers Jun 15, 2023
d3342a1
Update list_study calls
PGijsbers Jun 15, 2023
b8a915b
Update list_tasks to specify output_format dataframe
PGijsbers Jun 15, 2023
3361b15
Add `output_format` to `list_datasets` call
PGijsbers Jun 15, 2023
be16355
Add TODO markers for removing `dict` support of `list_*` functions
PGijsbers Jun 15, 2023
5cc1287
Make status check less strict, call list_dataset with output_format
PGijsbers Jun 15, 2023
576e09c
Change index on id to did, since thats the dataset id's column name
PGijsbers Jun 15, 2023
b82febe
Update test to reflect new error message
PGijsbers Jun 15, 2023
cc944b5
Fix bug introduced by refactor
PGijsbers Jun 15, 2023
dca2590
Fix minor oversights of refactoring
PGijsbers Jun 15, 2023
5240504
Merge branch 'develop' into pandas_default
PGijsbers Jun 15, 2023
3cff453
Rename variables to reflect they are no longer lists
PGijsbers Jun 16, 2023
c130c41
Fix unsafe indexing on dataframe and remaining unit tests
PGijsbers Jun 16, 2023
22a6dd3
Perform safer check for integer dtypes
PGijsbers Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move list_datasets test to proper file
  • Loading branch information
@PGijsbers
PGijsbers committed Jun 15, 2023
commit 29bbb57e975534a8fe0ea5ee16a1d2bfc97b7571
11 changes: 11 additions & 0 deletions tests/test_datasets/test_dataset_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1509,6 +1509,17 @@ def test_get_dataset_parquet(self):
self.assertIsNotNone(dataset.parquet_file)
self.assertTrue(os.path.isfile(dataset.parquet_file))

def test_list_datasets_with_high_size_parameter(self):
# Testing on prod since concurrent deletion of uploded datasets make the test fail
openml.config.server = self.production_server

datasets_a = openml.datasets.list_datasets(output_format="dataframe")
datasets_b = openml.datasets.list_datasets(output_format="dataframe", size=np.inf)

# Reverting to test server
openml.config.server = self.test_server
self.assertEqual(len(datasets_a), len(datasets_b))


@pytest.mark.parametrize(
"default_target_attribute,row_id_attribute,ignore_attribute",
Expand Down
14 changes: 0 additions & 14 deletions tests/test_utils/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
import tempfile
import unittest.mock

import numpy as np

import openml
from openml.testing import TestBase

Expand Down Expand Up @@ -58,18 +56,6 @@ def test_list_all_for_datasets(self):
for did in datasets:
self._check_dataset(datasets[did])

def test_list_datasets_with_high_size_parameter(self):
Comment thread
mfeurer marked this conversation as resolved.
# Testing on prod since concurrent deletion of uploded datasets make the test fail
openml.config.server = self.production_server

datasets_a = openml.datasets.list_datasets(output_format="dataframe")
datasets_b = openml.datasets.list_datasets(output_format="dataframe", size=np.inf)

# Reverting to test server
openml.config.server = self.test_server

self.assertEqual(len(datasets_a), len(datasets_b))

def test_list_all_for_tasks(self):
required_size = 1068 # default test server reset value
tasks = openml.tasks.list_tasks(batch_size=1000, size=required_size)
Expand Down