Skip to content

Mark sklearn tests #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 15 commits into from
Feb 23, 2023
Merged

Mark sklearn tests #1202

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
21cd8d7
Add sklearn marker
PGijsbers Feb 12, 2023
e2dcdc2
Mark tests that use scikit-learn
PGijsbers Feb 12, 2023
9ad6dae
Only run scikit-learn tests multiple times
PGijsbers Feb 12, 2023
d67b7cc
Rename for correct variable
PGijsbers Feb 20, 2023
f72ff8b
Add sklearn mark for filesystem test
PGijsbers Feb 20, 2023
e89db28
Remove quotes around sklearn
PGijsbers Feb 21, 2023
b547589
Instead include sklearn in the matrix definition
PGijsbers Feb 22, 2023
184c89c
Update jobnames
PGijsbers Feb 22, 2023
7a2a850
Add explicit false to jobname
PGijsbers Feb 22, 2023
657f0d3
Remove space
PGijsbers Feb 22, 2023
f36a040
Add function inside of expression?
PGijsbers Feb 22, 2023
ff34515
Do string testing instead
PGijsbers Feb 22, 2023
e549aa9
Add missing ${{
PGijsbers Feb 22, 2023
1db1ff7
Add explicit true to old sklearn tests
PGijsbers Feb 22, 2023
d01b4b2
Add instruction to add pytest marker for sklearn tests
PGijsbers Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add instruction to add pytest marker for sklearn tests
  • Loading branch information
@PGijsbers
PGijsbers committed Feb 23, 2023
commit d01b4b24c422daf1e7a4df9fb1d083b8d64c4910
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ following rules before you submit a pull request:

- Add [unit tests](https://github.com/openml/openml-python/tree/develop/tests) and [examples](https://github.com/openml/openml-python/tree/develop/examples) for any new functionality being introduced.
- If an unit test contains an upload to the test server, please ensure that it is followed by a file collection for deletion, to prevent the test server from bulking up. For example, `TestBase._mark_entity_for_removal('data', dataset.dataset_id)`, `TestBase._mark_entity_for_removal('flow', (flow.flow_id, flow.name))`.
- Please ensure that the example is run on the test server by beginning with the call to `openml.config.start_using_configuration_for_example()`.
- Please ensure that the example is run on the test server by beginning with the call to `openml.config.start_using_configuration_for_example()`.
- Add the `@pytest.mark.sklearn` marker to your unit tests if they have a dependency on scikit-learn.

- All tests pass when running `pytest`. On
Unix-like systems, check with (from the toplevel source folder):
Expand Down