Skip to content

Update more sklearn tests #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 4 commits into from
Oct 24, 2022
Merged

Update more sklearn tests #1175

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
647341c
n_iter is now keyword-only
PGijsbers Oct 17, 2022
0389aa6
Standardize sklearn pipeline description lookups
PGijsbers Oct 17, 2022
f80d645
`priors` is no longer positional, and wasn't used in the first place
PGijsbers Oct 17, 2022
85b7312
Remove loss=kneighbours from the complex pipelin
PGijsbers Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove loss=kneighbours from the complex pipelin
  • Loading branch information
@PGijsbers
PGijsbers committed Oct 17, 2022
commit 85b7312a4965bb5ca445df10a606a9d55ca05608
6 changes: 1 addition & 5 deletions tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,9 +1441,7 @@ def test_deserialize_complex_with_defaults(self):
"Estimator",
sklearn.ensemble.AdaBoostClassifier(
sklearn.ensemble.BaggingClassifier(
sklearn.ensemble.GradientBoostingClassifier(
sklearn.neighbors.KNeighborsClassifier()
)
sklearn.ensemble.GradientBoostingClassifier()
)
),
),
Expand All @@ -1458,7 +1456,6 @@ def test_deserialize_complex_with_defaults(self):
"Estimator__n_estimators": 10,
"Estimator__base_estimator__n_estimators": 10,
"Estimator__base_estimator__base_estimator__learning_rate": 0.1,
"Estimator__base_estimator__base_estimator__loss__n_neighbors": 13,
}
else:
params = {
Expand All @@ -1467,7 +1464,6 @@ def test_deserialize_complex_with_defaults(self):
"Estimator__n_estimators": 50,
"Estimator__base_estimator__n_estimators": 10,
"Estimator__base_estimator__base_estimator__learning_rate": 0.1,
"Estimator__base_estimator__base_estimator__loss__n_neighbors": 5,
}
pipe_adjusted.set_params(**params)
flow = self.extension.model_to_flow(pipe_adjusted)
Expand Down