Skip to content

Add scikit-learn 1.0 and 1.1 values for test #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 3 commits into from
Oct 7, 2022
Merged

Add scikit-learn 1.0 and 1.1 values for test #1168

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b72002a
Add scikit-learn 1.0 and 1.1 values for test
PGijsbers Sep 30, 2022
0f75cef
Remove min_impurity_split requirements for >=1.0
PGijsbers Oct 3, 2022
b0b19c2
Update KMeans checks for scikit-learn 1.0 and 1.1
PGijsbers Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove min_impurity_split requirements for >=1.0
  • Loading branch information
@PGijsbers
PGijsbers committed Oct 3, 2022
commit 0f75cef9d085ce58bf24204dd007c53733785325
20 changes: 19 additions & 1 deletion tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def test_serialize_model(self):
("splitter", '"best"'),
)
)
else:
elif LooseVersion(sklearn.__version__) < "1.0":
fixture_parameters = OrderedDict(
(
("class_weight", "null"),
Expand All @@ -186,6 +186,24 @@ def test_serialize_model(self):
("splitter", '"best"'),
)
)
else:
fixture_parameters = OrderedDict(
(
("class_weight", "null"),
("criterion", '"entropy"'),
("max_depth", "null"),
("max_features", '"auto"'),
("max_leaf_nodes", "2000"),
("min_impurity_decrease", "0.0"),
("min_samples_leaf", "1"),
("min_samples_split", "2"),
("min_weight_fraction_leaf", "0.0"),
("presort", presort_val),
("random_state", "null"),
("splitter", '"best"'),
)
)

if LooseVersion(sklearn.__version__) >= "0.22":
fixture_parameters.update({"ccp_alpha": "0.0"})
fixture_parameters.move_to_end("ccp_alpha", last=False)
Expand Down