Skip to content

Create a non-linear retry policy. #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 7 commits into from
May 10, 2021
Merged

Create a non-linear retry policy. #1065

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5e0d214
Create a non-linear retry policy.
PGijsbers Apr 28, 2021
761ad9d
Add retry_policy documentation
PGijsbers May 3, 2021
40e3493
Remove max_retries, add retry_policy to config
PGijsbers May 3, 2021
9f522f3
Add retry_policy so cli config
PGijsbers May 3, 2021
f857d53
Merge branch 'develop' into retry_policy
PGijsbers May 6, 2021
94927bc
Use policy to determine wait time
PGijsbers May 6, 2021
b7f73b4
Merge branch 'develop' into retry_policy
PGijsbers May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add retry_policy so cli config
  • Loading branch information
@PGijsbers
PGijsbers committed May 3, 2021
commit 9f522f34ce20cbc29bff41dcafa5ecd681f951d8
30 changes: 30 additions & 0 deletions openml/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,35 @@ def is_zero_through_two(verbosity: str) -> str:
)


def configure_retry_policy(value: str) -> None:
def is_known_policy(policy: str) -> str:
if policy in ["human", "robot"]:
return ""
return "Must be 'human' or 'robot'."

def autocomplete_policy(policy: str) -> str:
for option in ["human", "robot"]:
if option.startswith(policy.lower()):
return option
return policy

intro_message = (
"Set the retry policy which determines how to react if the server is unresponsive."
"We recommend 'human' for interactive usage and 'robot' for scripts."
"'human': try a few times in quick succession, less reliable but quicker response."
"'robot': try many times with increasing intervals, more reliable but slower response."
)

configure_field(
field="retry_policy",
value=value,
check_with_message=is_known_policy,
intro_message=intro_message,
input_message="Enter 'human' or 'robot': ",
sanitize=autocomplete_policy,
)


def configure_field(
field: str,
value: Union[None, str],
Expand Down Expand Up @@ -270,6 +299,7 @@ def configure(args: argparse.Namespace):
"apikey": configure_apikey,
"server": configure_server,
"cachedir": configure_cachedir,
"retry_policy": configure_retry_policy,
"connection_n_retries": configure_connection_n_retries,
"avoid_duplicate_runs": configure_avoid_duplicate_runs,
"verbosity": configure_verbosity,
Expand Down