Improve error messaging for expected errors

openml · PGijsbers · Mar 21, 2023 · Mar 3, 2021 · Mar 3, 2021 · Mar 3, 2021
commit 09db1404a5609bd92645b97ca64a21985fe62d71
diff --git a/openml/tasks/functions.py b/openml/tasks/functions.py
@@ -9,7 +9,7 @@
 import pandas as pd
 import xmltodict
 
-from ..exceptions import OpenMLCacheException
+from ..exceptions import OpenMLCacheException, OpenMLServerException, OpenMLNotAuthorizedError
 from ..datasets import get_dataset
 from .task import (
     OpenMLClassificationTask,
@@ -563,4 +563,20 @@ def delete_task(task_id: int) -> bool:
     bool
         True if the deletion was successful. False otherwise.
     """
-    return openml.utils._delete_entity("task", task_id)
+    try:
+        return openml.utils._delete_entity("task", task_id)
+    except OpenMLServerException as e:
+        # https://github.com/openml/OpenML/blob/21f6188d08ac24fcd2df06ab94cf421c946971b0/openml_OS/views/pages/api_new/v1/xml/pre.php#L234-L239  # noqa: 501
+        if e.code == 453:
+            raise OpenMLNotAuthorizedError(
+                message="The task can not be deleted because it was not uploaded by you.",
+                code=e.code,
+                url=e.url,
+            )
+        if e.code == 454:
+            raise OpenMLNotAuthorizedError(
+                message="The task can not be deleted because it still has associated runs.",
+                code=e.code,
+                url=e.url,
+            )
+        raise