Skip to content

Configuration ci #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 15 commits into from
Apr 20, 2021
Merged

Configuration ci #1049

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
436b314
Add a non-functional entry point
PGijsbers Apr 6, 2021
0f812f2
Allow setting of API key through CLI
PGijsbers Apr 8, 2021
ef8434b
Remove autocomplete promise, use _defaults
PGijsbers Apr 8, 2021
a64b3e9
Add server configuration
PGijsbers Apr 8, 2021
2ff55d9
Allow fields to be set directly non-interactively
PGijsbers Apr 9, 2021
8c00fc0
Combine error and check functionalities
PGijsbers Apr 9, 2021
a41c41f
Share logic about setting/collecting the value
PGijsbers Apr 9, 2021
7703d3b
Complete CLI for other fields.
PGijsbers Apr 9, 2021
75e3783
Bring back sanitizing user input
PGijsbers Apr 9, 2021
a41b144
Add small bit of info about the command line tool
PGijsbers Apr 9, 2021
fb2c56b
Add API key configuration note in the introduction
PGijsbers Apr 9, 2021
cd36117
Merge branch 'develop' into configuration_ci
PGijsbers Apr 9, 2021
149065d
Add to progress log
PGijsbers Apr 9, 2021
935ee25
Refactor flow of wait_until_valid_input
PGijsbers Apr 9, 2021
8560d8b
Merge branch 'develop' into configuration_ci
PGijsbers Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove autocomplete promise, use _defaults 
Autocomplete seems to be incompatible with `choices`, so I'll ignore
that for now. We also use `config._defaults` instead of an explicit
list to avoid duplication.
  • Loading branch information
@PGijsbers
PGijsbers committed Apr 8, 2021
commit ef8434b88861cb305542157d2ce8f81700b4b2c8
14 changes: 2 additions & 12 deletions openml/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,20 +105,10 @@ def main() -> None:
parser_configure.add_argument(
"field",
type=str,
choices=[
"apikey",
"server",
"cachedir",
"avoid_duplicate_runs",
"connection_n_retries",
"verbosity",
"all",
"none",
],
choices=[*config._defaults.keys(), "all", "none"],
default="all",
nargs="?",
help="The field you wish to edit, auto-completes the field name, "
"e.g. `openml configure cache` is equivalent to `openml configure cachedir`."
help="The field you wish to edit."
"Choosing 'all' lets you configure all fields one by one."
"Choosing 'none' will print out the current configuration.",
)
Expand Down
14 changes: 3 additions & 11 deletions openml/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,22 +265,14 @@ def _get(config, key):

def set_field_in_config_file(field: str, value: Any):
""" Overwrites the `field` in the configuration file with the new `value`. """
fields = [
"apikey",
"server",
"cache_directory",
"avoid_duplicate_runs",
"connection_n_retries",
"max_retries",
]
if field not in fields:
return ValueError(f"Field '{field}' is not valid and must be one of '{fields}'.")
if field not in _defaults:
return ValueError(f"Field '{field}' is not valid and must be one of '{_defaults.keys()}'.")

globals()[field] = value
config_file = determine_config_file_path()
config = _parse_config(str(config_file))
with open(config_file, "w") as fh:
for f in fields:
for f in _defaults.keys():
# We can't blindly set all values based on globals() because the user when the user
# sets it through config.FIELD it should not be stored to file.
value = config.get("FAKE_SECTION", f)
Expand Down