Skip to content

Standardize use of n_jobs and reporting of computation time #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 16 commits into from
Apr 13, 2021
Merged

Standardize use of n_jobs and reporting of computation time #1038

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
82a5ff6
Unit test to test existence of refit time
Neeratyoy Feb 24, 2021
0566220
Measuring runtime always
Neeratyoy Mar 23, 2021
e527bea
Removing redundant check in unit test
Neeratyoy Mar 23, 2021
c2d2757
Updating docs with runtimes
Neeratyoy Mar 23, 2021
7559c74
Adding more utilities to new example
Neeratyoy Mar 29, 2021
be73637
Removing refit_time + fetching trace runtime in example
Neeratyoy Mar 30, 2021
b7e0ae5
Merge branch 'develop' into fix_895
Neeratyoy Mar 30, 2021
dcaf34b
rename example
mfeurer Mar 31, 2021
ba19ab7
Reiterating with changes to example from @mfeurer suggestions
Neeratyoy Apr 5, 2021
5450c2a
Including refit time and other minor formatting
Neeratyoy Apr 6, 2021
7af70ee
Adding more cases + a concluding summary
Neeratyoy Apr 7, 2021
f75d8f3
Cosmetic changes
Neeratyoy Apr 8, 2021
afd69fd
Adding 5th case with no release of GIL
Neeratyoy Apr 12, 2021
a73d42f
Merge branch 'develop' into fix_895
Neeratyoy Apr 12, 2021
9e1b023
Removing debug code
Neeratyoy Apr 12, 2021
d81eed0
Runtime measurement example updates (#1052)
mfeurer Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Unit test to test existence of refit time
  • Loading branch information
@Neeratyoy
Neeratyoy committed Mar 12, 2021
commit 82a5ff623938918f499a1c27495d245429e7d834
12 changes: 12 additions & 0 deletions tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2260,3 +2260,15 @@ def column_transformer_pipe(task_id):
run2 = column_transformer_pipe(23) # only numeric
TestBase._mark_entity_for_removal("run", run2.run_id)
self.assertEqual(run1.setup_id, run2.setup_id)

def test_for_refit_time_in_basesearchCV(self):
Comment thread
mfeurer marked this conversation as resolved.
Outdated
X, y = sklearn.datasets.load_iris(return_X_y=True)
rs = sklearn.model_selection.GridSearchCV(
estimator=sklearn.ensemble.RandomForestClassifier(),
param_grid={"n_estimators": [2, 3, 4, 5]},
)
rs.fit(X, y)
if LooseVersion(sklearn.__version__) < "0.20":
self.assertFalse(hasattr(rs, "refit_time_"))
else:
self.assertTrue(hasattr(rs, "refit_time_"))