Skip to content

API for topics #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 3 commits into from
Mar 9, 2021
Merged

API for topics #1023

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59fb25c
initial commit
sahithyaravi Feb 14, 2021
d812842
Merge branch 'develop' into topic_apis
sahithyaravi Mar 8, 2021
f14a8e9
private functions
sahithyaravi Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
private functions
  • Loading branch information
@sahithyaravi
sahithyaravi committed Mar 8, 2021
commit f14a8e9bd96cd4af6127dee5caa7c3f5f76e21b3
4 changes: 0 additions & 4 deletions openml/datasets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
list_qualities,
edit_dataset,
fork_dataset,
topic_add_dataset,
topic_delete_dataset,
)
from .dataset import OpenMLDataset
from .data_feature import OpenMLDataFeature
Expand All @@ -30,6 +28,4 @@
"list_qualities",
"edit_dataset",
"fork_dataset",
"topic_add_dataset",
"topic_delete_dataset",
]
4 changes: 2 additions & 2 deletions openml/datasets/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ def fork_dataset(data_id: int) -> int:
return int(data_id)


def topic_add_dataset(data_id: int, topic: str):
def _topic_add_dataset(data_id: int, topic: str):
"""
Adds a topic for a dataset.
This API is not available for all OpenML users and is accessible only by admins.
Expand All @@ -893,7 +893,7 @@ def topic_add_dataset(data_id: int, topic: str):
return int(data_id)


def topic_delete_dataset(data_id: int, topic: str):
def _topic_delete_dataset(data_id: int, topic: str):
"""
Removes a topic from a dataset.
This API is not available for all OpenML users and is accessible only by admins.
Expand Down
8 changes: 5 additions & 3 deletions tests/test_datasets/test_dataset_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@
_get_online_dataset_format,
DATASETS_CACHE_DIR_NAME,
_get_dataset_parquet,
_topic_add_dataset,
_topic_delete_dataset,
)
from openml.datasets import fork_dataset, edit_dataset, topic_add_dataset, topic_delete_dataset
from openml.datasets import fork_dataset, edit_dataset
from openml.tasks import TaskType, create_task


Expand Down Expand Up @@ -916,15 +918,15 @@ def test_topic_api_error(self):
self.assertRaisesRegex(
OpenMLServerException,
"Topic can only be added/removed by admin.",
topic_add_dataset,
_topic_add_dataset,
data_id=31,
topic="business",
)
# Check server exception when non-admin accessses apis
self.assertRaisesRegex(
OpenMLServerException,
"Topic can only be added/removed by admin.",
topic_delete_dataset,
_topic_delete_dataset,
data_id=31,
topic="business",
)
Expand Down