Skip to content

Adding sklearn min. dependencies for all versions #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 3 commits into from
Feb 18, 2021
Merged

Adding sklearn min. dependencies for all versions #1022

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ea2e72
Squashing commits
Neeratyoy Feb 15, 2021
8442576
All flow dependencies for sklearn>0.24 will change now
Neeratyoy Feb 16, 2021
ffb4a2d
Dep. string change only for OpenML>v0.11
Neeratyoy Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
All flow dependencies for sklearn>0.24 will change now
  • Loading branch information
@Neeratyoy
Neeratyoy committed Feb 16, 2021
commit 844257695a59c37f0eb9d6d618304723b991bd4d
9 changes: 1 addition & 8 deletions openml/extensions/sklearn/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,20 +804,13 @@ def _serialize_model(self, model: Any) -> OpenMLFlow:
tags=tags,
extension=self,
language="English",
# TODO fill in dependencies!
dependencies=dependencies,
)

return flow

def _get_dependencies(self) -> str:
dependencies = "\n".join(
[
self._format_external_version("sklearn", sklearn.__version__,),
"numpy>=1.6.1",
"scipy>=0.9",
]
)
dependencies = self._min_dependency_str(sklearn.__version__)
return dependencies

def _get_tags(self) -> List[str]:
Expand Down