Skip to content

Feature/give possibility to not download the dataset qualities #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 11 commits into from
Feb 11, 2021
Merged

Feature/give possibility to not download the dataset qualities #1017

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
48653e2
update getdatasets function to give possibility to not download the d…
Jan 7, 2021
6cc1952
make download qualities defaulted to True
Jan 7, 2021
4ec995f
Using cahced version if exist
Jan 8, 2021
611d2bf
Updated the comments for get_dataset and get_datasets to include new …
Jan 12, 2021
d5d3a15
Update openml/datasets/functions.py
a-moadel Jan 13, 2021
08a3c41
Update openml/datasets/functions.py
a-moadel Jan 13, 2021
c3d9684
update get_dataset_qualities to have consistent output regardless the…
madel0093 Jan 17, 2021
84b9a8f
run pre-commit
madel0093 Jan 17, 2021
63b791d
fix parameter passing
Jan 26, 2021
55c7196
Merge branch 'feature/give_possibility_to_not_download_the_dataset_qu…
Jan 26, 2021
1b6467d
Updated the comments for get_dataset and get_datasets to include new …
Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make download qualities defaulted to True
  • Loading branch information
Mohamed Adel committed Jan 7, 2021
commit 6cc19526a2f9ab0c450c5c7222715efc4fdd5055
15 changes: 8 additions & 7 deletions openml/datasets/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,7 @@ def _name_to_id(


def get_datasets(
dataset_ids: List[Union[str, int]], download_data: bool = True,
download_qualities: bool = True
dataset_ids: List[Union[str, int]], download_data: bool = True, download_qualities: bool = True
) -> List[OpenMLDataset]:
"""Download datasets.

Expand Down Expand Up @@ -346,7 +345,8 @@ def get_dataset(
version: int = None,
error_if_multiple: bool = False,
cache_format: str = "pickle",
download_qualities: bool = True) -> OpenMLDataset:
download_qualities: bool = True,
) -> OpenMLDataset:
""" Download the OpenML dataset representation, optionally also download actual data file.

This function is thread/multiprocessing safe.
Expand Down Expand Up @@ -406,7 +406,9 @@ def get_dataset(
features_file = _get_dataset_features_file(did_cache_dir, dataset_id)

try:
qualities_file = _get_dataset_qualities_file(did_cache_dir, dataset_id,download_qualities)
qualities_file = _get_dataset_qualities_file(
Copy link
Copy Markdown
Collaborator

@PGijsbers PGijsbers Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to use download_qualities here and not call the _get_dataset_qualities_file if we don't want to process the qualities.

did_cache_dir, dataset_id, download_qualities
)
except OpenMLServerException as e:
if e.code == 362 and str(e) == "No qualities found - None":
logger.warning("No qualities found for dataset {}".format(dataset_id))
Expand Down Expand Up @@ -982,7 +984,7 @@ def _get_dataset_features_file(did_cache_dir: str, dataset_id: int) -> str:
return features_file


def _get_dataset_qualities_file(did_cache_dir, dataset_id,download_qualities):
def _get_dataset_qualities_file(did_cache_dir, dataset_id, download_qualities=True):
"""API call to load dataset qualities. Loads from cache or downloads them.

Features are metafeatures (number of features, number of classes, ...)
Expand All @@ -1002,7 +1004,7 @@ def _get_dataset_qualities_file(did_cache_dir, dataset_id,download_qualities):
str
Path of the cached qualities file
"""
if download_qualities == True:
if download_qualities:
# Dataset qualities are subject to change and must be fetched every time
qualities_file = os.path.join(did_cache_dir, "qualities.xml")
try:
Expand All @@ -1017,7 +1019,6 @@ def _get_dataset_qualities_file(did_cache_dir, dataset_id,download_qualities):
return qualities_file
else:
pass



def _create_dataset_from_description(
Expand Down