Initialize comprehensive theming volumes for devstack_docker services… by ztraboo · Pull Request #377 · openedx-unsupported/devstack

ztraboo · 2018-12-18T20:25:12Z

Setup comprehensive theming volumes for devstack_docker services to also include the watcher containers.

… to also include watchers.

openedx-webhooks · 2018-12-18T20:25:26Z

Thanks for the pull request, @ztraboo! I've created OSPR-2916 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information.

natabene · 2018-12-19T03:30:28Z

@ztraboo Thank you for the contribution! When you have a chance, could you please send in a signed Contributor Agreement mentioned in the earlier comment? You only need to do this once and we can then review all your future code contributions.

ztraboo · 2018-12-19T12:09:52Z

@natabene I sent my signed CA document into edX legal yesterday afternoon.

From: Zachary J Trabookis ztraboo@clemson.edu
Sent: Tuesday, December 18, 2018 1:52 PM
To: legal@edx.org
Subject: Open edX - Contributor Agreement - Zachary Trabookis (ztraboo)

natabene · 2018-12-19T18:37:15Z

@ztraboo Thank you, once our team processes it, I will post an update here.

natabene · 2019-03-18T17:14:48Z

@ztraboo Thank you for joining the Open edX community! We have added your user to our records and can now review your code going forward. @edx/devops Could you give this a look?

abhiyan52 · 2019-05-28T17:10:19Z

Hey, I want to change static themes files in my docker container in order to customize the theme. How can I do that without docker copy and restarting

natabene · 2019-05-28T17:54:32Z

Hey, I want to change static themes files in my docker container in order to customize the theme. How can I do that without docker copy and restarting

@nedbat Could you help us out here?

natabene · 2019-06-03T15:11:27Z

@jmbowman Could you give a look?

jmbowman · 2019-06-04T21:11:48Z


 dev.up: | check-memory ## Bring up all services with host volumes
-	bash -c 'docker-compose -f docker-compose.yml -f docker-compose-host.yml up -d'
+	bash -c 'docker-compose -f docker-compose.yml -f docker-compose-host.yml -f docker-compose-themes.yml up -d'


If we add this here, it seems like it should also be added to each of the commands in this file that use -f docker-compose-host.yml (especially dev.provision.run and dev.up.%). Probably in destroy.sh and marketing.mk also.

…ve-Theme-Volumes-For-LMS-and-Studio

… to include all services that include a `docker-compose-host.yml`.

jmbowman

This looks ok to me; most people won't have access to the edx-themes repository, but it shouldn't hurt anything if absent (an empty directory will just get created on the host system).

Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377

https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup.

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup.

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup. Additional changes needed to make `docker` commands work making use of the `dev.print-container.%` target to get the container id. Reverting some of these commands back to `docker` type to align with what we did with edx/devstack@59f812e Updated `README` to include necessary information when running multiple isolated devstacks for same host. Make additional adjustments to the documentation for multiple releases one machine. Add `xqueue` to default services to provision initially. Make sure to pass in `DOCKER_COMPOSE_FILES` to `docker-compose exec` commands for services outside of `docker-compose.yml`. Makes sure that other services (e.g. `xqueue`, etc) that are not defined in the docker-compose.yml file have the correct configuration passed to the `docker-compose exec` command to work properly.

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup.

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup. Additional changes needed to make `docker` commands work making use of the `dev.print-container.%` target to get the container id. Reverting some of these commands back to `docker` type to align with what we did with edx/devstack@59f812e

…ers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request openedx-unsupported#532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. openedx-unsupported#376 openedx-unsupported#377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup. Additional changes needed to make `docker` commands work making use of the `dev.print-container.%` target to get the container id. Reverting some of these commands back to `docker` type to align with what we did with 59f812e

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup. Additional changes needed to make `docker` commands work making use of the `dev.print-container.%` target to get the container id. Reverting some of these commands back to `docker` type to align with what we did with edx/devstack@59f812e

Initialize comprehensive theming volumes for devstack_docker services…

391a6b3

… to also include watchers.

openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Dec 18, 2018

openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Dec 19, 2018

openedx-webhooks added community manager review and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Feb 15, 2019

natabene requested a review from jdmulloy March 18, 2019 17:14

openedx-webhooks added awaiting prioritization and removed community manager review labels Mar 18, 2019

openedx-webhooks added needs triage and removed awaiting prioritization labels May 21, 2019

openedx-unsupported deleted a comment from openedx-webhooks May 22, 2019

natabene requested a review from jmbowman June 3, 2019 15:12

jmbowman reviewed Jun 4, 2019

View reviewed changes

ztraboo added 2 commits June 6, 2019 08:17

Merge remote-tracking branch 'origin/master' into ztraboo/Comprehensi…

fb02489

…ve-Theme-Volumes-For-LMS-and-Studio

Initialize comprehensive theming volumes for devstack_docker services…

3d74e38

… to include all services that include a `docker-compose-host.yml`.

jmbowman approved these changes Jun 6, 2019

View reviewed changes

jmbowman merged commit 99920e1 into openedx-unsupported:master Jun 6, 2019

ztraboo mentioned this pull request Jul 24, 2020

[Backport] Multiple devstack releases with one machine #564

Merged

openedx-webhooks added merged and removed needs triage labels Jan 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Initialize comprehensive theming volumes for devstack_docker services…#377

Initialize comprehensive theming volumes for devstack_docker services…#377
jmbowman merged 3 commits into
openedx-unsupported:masterfrom
CUCWD:ztraboo/Comprehensive-Theme-Volumes-For-LMS-and-Studio

ztraboo commented Dec 18, 2018

Uh oh!

openedx-webhooks commented Dec 18, 2018

Uh oh!

natabene commented Dec 19, 2018

Uh oh!

ztraboo commented Dec 19, 2018

Uh oh!

natabene commented Dec 19, 2018

Uh oh!

natabene commented Mar 18, 2019

Uh oh!

abhiyan52 commented May 28, 2019

Uh oh!

natabene commented May 28, 2019

Uh oh!

natabene commented Jun 3, 2019

Uh oh!

jmbowman Jun 4, 2019

Uh oh!

jmbowman left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ztraboo commented Dec 18, 2018

Uh oh!

openedx-webhooks commented Dec 18, 2018

Uh oh!

natabene commented Dec 19, 2018

Uh oh!

ztraboo commented Dec 19, 2018

Uh oh!

natabene commented Dec 19, 2018

Uh oh!

natabene commented Mar 18, 2019

Uh oh!

abhiyan52 commented May 28, 2019

Uh oh!

natabene commented May 28, 2019

Uh oh!

natabene commented Jun 3, 2019

Uh oh!

jmbowman Jun 4, 2019

Choose a reason for hiding this comment

Uh oh!

jmbowman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants