fix(telegram): allow agentId in account config for multi-account routing#63380
fix(telegram): allow agentId in account config for multi-account routing#63380mraleko wants to merge 5 commits intoopenclaw:mainfrom
Conversation
Greptile SummaryFixes a regression introduced between 2026.4.5 and 2026.4.8 where Telegram multi-account configs using Confidence Score: 5/5Safe to merge — targeted schema fix with regression test coverage and no behavioral side effects. The only finding is a P2 style issue (new test placed in the wrong describe block). The core fix is minimal, correct, and type-consistent with the existing topic-level agentId pattern. src/config/config.telegram-topic-agentid.test.ts — the account-level agentId regression test belongs in its own describe block.
|
Allows agentId in channels.telegram.accounts.<id> for per-account agent routing in multi-account setups. Fixes regression where upgrading from 2026.4.5 to 2026.4.8 caused 'must NOT have additional properties' errors for accounts with agentId configured.
Resolves Greptile P2 review comment: test was nested inside
telegram disableAudioPreflight schema block (semantically unrelated).
Now in dedicated describe("telegram account agentId schema") block.
43e7474 to
26aa82c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26aa82ccf0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…flight describe block
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a303af40a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Addressed the account-level
Validated with:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8965daf69b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Addressed the remaining Telegram
Validated with:
|
Summary
Fixes regression where Telegram multi-account configs with
agentIdwere rejected as 'must NOT have additional properties' after upgrading from 2026.4.5 to 2026.4.8.Root cause
agentIdwas only defined inTelegramTopicSchema(for forum group topic routing), not inTelegramAccountSchemaBase. The.strict()Zod modifier generatesadditionalProperties: falsein JSON Schema, causing account configs withagentIdto fail validation.Changes
agentId?: stringtoTelegramAccountConfigtypeagentId: z.string().optional()toTelegramAccountSchemaBaseZod schema (afterenabledfield)agentIdin account configTesting
agentIdnow passes, multi-account config (6 accounts each withagentId) passes, backward compatibility preservedFixes #62985