Use isort black profile to make compatible with black#523
Merged
dbanty merged 5 commits intoopenapi-generators:mainfrom Oct 25, 2021
johnthagen:patch-1
Merged
Use isort black profile to make compatible with black#523dbanty merged 5 commits intoopenapi-generators:mainfrom johnthagen:patch-1
dbanty merged 5 commits intoopenapi-generators:mainfrom
johnthagen:patch-1
Conversation
Collaborator
|
Apparently I did this for the generator itself at some point but forgot to update to update the templates 😅. Could you update the no_poetry template too? Thanks!! |
Collaborator
Author
Done. |
Codecov Report
@@ Coverage Diff @@
## main #523 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 1639 1639
=========================================
Hits 1639 1639
Continue to review full report at Codecov.
|
Collaborator
|
I decided to merge the two templates so it'll be easier to maintain in the future. Thanks for the contribution! |
dbanty
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The best way to use
isortwithblackis to use the dedicatedblackprofile: https://pycqa.github.io/isort/docs/configuration/profiles.html